From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/4] build: Hook the schedulers into Kconfig Date: Fri, 18 Dec 2015 12:23:31 +0100 Message-ID: <1450437811.19320.126.camel@citrix.com> References: <1450385974-12732-1-git-send-email-jonathan.creekmore@gmail.com> <1450385974-12732-2-git-send-email-jonathan.creekmore@gmail.com> <1450402503.19320.97.camel@citrix.com> <5673E582.6030000@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2752487855318446557==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a9t8N-0000a3-G2 for xen-devel@lists.xenproject.org; Fri, 18 Dec 2015 11:23:39 +0000 In-Reply-To: <5673E582.6030000@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , Jonathan Creekmore , xen-devel@lists.xenproject.org Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============2752487855318446557== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-F3oHPQ9rnkkjG8RKwjrH" --=-F3oHPQ9rnkkjG8RKwjrH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-12-18 at 10:52 +0000, George Dunlap wrote: > On 18/12/15 01:35, Dario Faggioli wrote: > > On Thu, 2015-12-17 at 14:59 -0600, Jonathan Creekmore wrote: > > > Allow the schedulers to be independently enabled or disabled at > > > compile-time instead of just allowing the scheduler to be > > > selected on > > > the command line.=20 > > >=20 > > Reading this quickly, that "instead" gave me a bit of an hard time. > > I'm > > not a native English speaker, and I'm sure it's me that am wrong, > > but > > for some reason the sentence made me think that the patch would > > somehow > > disallow specifying a scheduler during boot, in Xen's command line. >=20 > I think the "just" in the sentence is an attempt to disambiguate > (i.e., > instead of *only* allowing the scheduler to be chosen on the > command-line, *also* allow it to be chosen at compile-time). >=20 Indeed (for what my opinion on English grammar is worth :-D). That "just" was what made me eventually get the meaning (together with looking at the code). And, in fact, I don't dispute correctness, it's just... > But I agree that the whole clause isn't really necessary and it would > be > clearer without it. >=20 ... this :-D Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-F3oHPQ9rnkkjG8RKwjrH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlZz7LQACgkQk4XaBE3IOsROPQCfSQ7ZWdGpzFbMqpgYkfcu+nCN CQAAn39FyNT7aGkOb/Ke/K0s1JriUhB3 =lpez -----END PGP SIGNATURE----- --=-F3oHPQ9rnkkjG8RKwjrH-- --===============2752487855318446557== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2752487855318446557==--