From: Quan Xu <quan.xu@intel.com>
To: jbeulich@suse.com, kevin.tian@intel.com
Cc: feng.wu@intel.com, eddie.dong@intel.com,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
tim@xen.org, xen-devel@lists.xen.org, jun.nakajima@intel.com,
Quan Xu <quan.xu@intel.com>,
keir@xen.org
Subject: [PATCH v4 0/3] VT-d Device-TLB flush issue
Date: Wed, 23 Dec 2015 16:25:33 +0800 [thread overview]
Message-ID: <1450859136-98482-1-git-send-email-quan.xu@intel.com> (raw)
This patches are based on Kevin Tian's previous discussion 'Revisit VT-d asynchronous flush issue'.
Fix current timeout concern and also allow limited ATS support in a light way:
1. Check VT-d Device-TLB flush error.
This patch checks all kinds of error and all the way up the call trees of VT-d Device-TLB flush.
2. Reduce spin timeout to 1ms, which can be boot-time changed with 'iommu_qi_timeout_ms'.
For example:
multiboot /boot/xen.gz ats=1 iommu_qi_timeout_ms=100
3. Fix vt-d Device-TLB flush timeout issue.
Now if IOTLB/Context/IETC flush is timeout, panic hypervisor. The coming patch
set will fix it.
If Device-TLB flush is timeout, we'll hide the target ATS
device and crash the domain owning this ATS device.
If impacted domain is hardware domain, just throw out a warning.
The hided Device will be disallowed to be further assigned to
any domain.
--
* DMAR_OPERATION_TIMEOUT should be also chopped down to a low number of milliseconds.
As Kevin Tian mentioned in 'Revisit VT-d asynchronous flush issue', We also confirmed with hardware team
that 1ms is large enough for IOMMU internal flush. So I can change DMAR_OPERATION_TIMEOUT from 1000 ms to 1 ms.
IOMMU_WAIT_OP() is only for VT-d registers read/write, and there is also a panic. We need a further discussion
whether or how to remove this panic in next patch set.
* if IOTLB/Context/IETC flush is timeout, panic hypervisor. The coming patch set will fix it.
Quan Xu (3):
VT-d: Check VT-d Device-TLB flush error.
VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.
VT-d: Fix vt-d Device-TLB flush timeout issue.
xen/arch/x86/acpi/power.c | 8 +-
xen/arch/x86/crash.c | 3 +-
xen/arch/x86/domain_build.c | 5 +-
xen/arch/x86/mm.c | 15 ++-
xen/arch/x86/mm/p2m-ept.c | 14 ++-
xen/arch/x86/mm/p2m-pt.c | 14 ++-
xen/arch/x86/mm/p2m.c | 19 +++-
xen/arch/x86/x86_64/mm.c | 7 +-
xen/common/domain.c | 3 +-
xen/common/grant_table.c | 5 +-
xen/common/memory.c | 13 ++-
xen/drivers/passthrough/amd/iommu_init.c | 4 +-
xen/drivers/passthrough/amd/pci_amd_iommu.c | 4 +-
xen/drivers/passthrough/arm/smmu.c | 13 ++-
xen/drivers/passthrough/iommu.c | 47 +++++---
xen/drivers/passthrough/pci.c | 2 +-
xen/drivers/passthrough/vtd/extern.h | 6 +-
xen/drivers/passthrough/vtd/iommu.c | 157 ++++++++++++++++++++------
xen/drivers/passthrough/vtd/qinval.c | 93 ++++++++++++++-
xen/drivers/passthrough/vtd/quirks.c | 26 +++--
xen/drivers/passthrough/vtd/x86/ats.c | 13 +++
xen/drivers/passthrough/vtd/x86/vtd.c | 13 ++-
xen/drivers/passthrough/x86/iommu.c | 6 +-
xen/include/asm-x86/hvm/svm/amd-iommu-proto.h | 4 +-
xen/include/asm-x86/iommu.h | 2 +-
xen/include/xen/iommu.h | 20 ++--
26 files changed, 403 insertions(+), 113 deletions(-)
--
1.9.1
next reply other threads:[~2015-12-23 8:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:25 Quan Xu [this message]
2015-12-23 8:25 ` [PATCH v4 1/3] VT-d: Check VT-d Device-TLB flush error Quan Xu
2015-12-25 2:53 ` Tian, Kevin
2016-01-06 2:12 ` Xu, Quan
2016-01-14 17:01 ` Jan Beulich
2016-01-14 17:15 ` Jan Beulich
2015-12-23 8:25 ` [PATCH v4 2/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed Quan Xu
2015-12-25 2:56 ` Tian, Kevin
2015-12-25 2:58 ` Xu, Quan
2016-01-13 16:55 ` Jan Beulich
2016-01-14 1:53 ` Xu, Quan
2016-01-13 16:57 ` Jan Beulich
2016-01-14 1:59 ` Xu, Quan
2016-01-14 9:03 ` Jan Beulich
2016-01-14 10:29 ` Xu, Quan
2016-01-14 12:17 ` Jan Beulich
2015-12-23 8:25 ` [PATCH v4 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue Quan Xu
2015-12-25 3:06 ` Tian, Kevin
2016-01-06 11:25 ` Xu, Quan
2016-01-15 13:09 ` Jan Beulich
2016-01-20 10:26 ` Xu, Quan
2016-01-20 11:29 ` Jan Beulich
2016-01-21 16:16 ` Xu, Quan
2016-01-21 16:31 ` Jan Beulich
2016-01-22 15:57 ` Xu, Quan
2016-01-25 14:09 ` Jan Beulich
2016-01-26 13:47 ` Xu, Quan
2016-01-26 13:59 ` Jan Beulich
2016-01-26 15:27 ` Xu, Quan
2016-01-26 15:52 ` Jan Beulich
2016-01-26 22:47 ` Tian, Kevin
2016-01-27 11:09 ` Xu, Quan
2016-01-27 11:24 ` Jan Beulich
2016-01-27 12:38 ` Xu, Quan
2016-01-27 13:15 ` Jan Beulich
2016-01-27 14:13 ` Xu, Quan
2016-01-27 14:29 ` Jan Beulich
2016-01-27 14:35 ` Xu, Quan
2015-12-23 10:19 ` [PATCH v4 0/3] VT-d Device-TLB flush issue Xu, Quan
2015-12-23 10:40 ` Jan Beulich
2015-12-23 10:59 ` Xu, Quan
2015-12-23 10:39 ` Jan Beulich
2015-12-23 11:09 ` Xu, Quan
2015-12-25 1:50 ` Tian, Kevin
2015-12-25 2:26 ` Xu, Quan
2015-12-25 1:53 ` Tian, Kevin
2015-12-25 2:04 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450859136-98482-1-git-send-email-quan.xu@intel.com \
--to=quan.xu@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=feng.wu@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).