From: Quan Xu <quan.xu@intel.com>
To: jbeulich@suse.com, kevin.tian@intel.com
Cc: feng.wu@intel.com, eddie.dong@intel.com,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
tim@xen.org, xen-devel@lists.xen.org, jun.nakajima@intel.com,
Quan Xu <quan.xu@intel.com>,
keir@xen.org
Subject: [PATCH v4 2/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.
Date: Wed, 23 Dec 2015 16:25:35 +0800 [thread overview]
Message-ID: <1450859136-98482-3-git-send-email-quan.xu@intel.com> (raw)
In-Reply-To: <1450859136-98482-1-git-send-email-quan.xu@intel.com>
Signed-off-by: Quan Xu <quan.xu@intel.com>
---
xen/drivers/passthrough/vtd/qinval.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
index 946e812..b227e4e 100644
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -28,6 +28,11 @@
#include "vtd.h"
#include "extern.h"
+static int __read_mostly iommu_qi_timeout_ms = 1;
+integer_param("iommu_qi_timeout_ms", iommu_qi_timeout_ms);
+
+#define IOMMU_QI_TIMEOUT (iommu_qi_timeout_ms * MILLISECS(1))
+
static void print_qi_regs(struct iommu *iommu)
{
u64 val;
@@ -167,10 +172,12 @@ static int queue_invalidate_wait(struct iommu *iommu,
start_time = NOW();
while ( poll_slot != QINVAL_STAT_DONE )
{
- if ( NOW() > (start_time + DMAR_OPERATION_TIMEOUT) )
+ if ( NOW() > (start_time + IOMMU_QI_TIMEOUT) )
{
print_qi_regs(iommu);
- panic("queue invalidate wait descriptor was not executed");
+ dprintk(XENLOG_WARNING VTDPREFIX,
+ "Queue invalidate wait descriptor was timeout.\n");
+ return -ETIMEDOUT;
}
cpu_relax();
}
--
1.9.1
next prev parent reply other threads:[~2015-12-23 8:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:25 [PATCH v4 0/3] VT-d Device-TLB flush issue Quan Xu
2015-12-23 8:25 ` [PATCH v4 1/3] VT-d: Check VT-d Device-TLB flush error Quan Xu
2015-12-25 2:53 ` Tian, Kevin
2016-01-06 2:12 ` Xu, Quan
2016-01-14 17:01 ` Jan Beulich
2016-01-14 17:15 ` Jan Beulich
2015-12-23 8:25 ` Quan Xu [this message]
2015-12-25 2:56 ` [PATCH v4 2/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed Tian, Kevin
2015-12-25 2:58 ` Xu, Quan
2016-01-13 16:55 ` Jan Beulich
2016-01-14 1:53 ` Xu, Quan
2016-01-13 16:57 ` Jan Beulich
2016-01-14 1:59 ` Xu, Quan
2016-01-14 9:03 ` Jan Beulich
2016-01-14 10:29 ` Xu, Quan
2016-01-14 12:17 ` Jan Beulich
2015-12-23 8:25 ` [PATCH v4 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue Quan Xu
2015-12-25 3:06 ` Tian, Kevin
2016-01-06 11:25 ` Xu, Quan
2016-01-15 13:09 ` Jan Beulich
2016-01-20 10:26 ` Xu, Quan
2016-01-20 11:29 ` Jan Beulich
2016-01-21 16:16 ` Xu, Quan
2016-01-21 16:31 ` Jan Beulich
2016-01-22 15:57 ` Xu, Quan
2016-01-25 14:09 ` Jan Beulich
2016-01-26 13:47 ` Xu, Quan
2016-01-26 13:59 ` Jan Beulich
2016-01-26 15:27 ` Xu, Quan
2016-01-26 15:52 ` Jan Beulich
2016-01-26 22:47 ` Tian, Kevin
2016-01-27 11:09 ` Xu, Quan
2016-01-27 11:24 ` Jan Beulich
2016-01-27 12:38 ` Xu, Quan
2016-01-27 13:15 ` Jan Beulich
2016-01-27 14:13 ` Xu, Quan
2016-01-27 14:29 ` Jan Beulich
2016-01-27 14:35 ` Xu, Quan
2015-12-23 10:19 ` [PATCH v4 0/3] VT-d Device-TLB flush issue Xu, Quan
2015-12-23 10:40 ` Jan Beulich
2015-12-23 10:59 ` Xu, Quan
2015-12-23 10:39 ` Jan Beulich
2015-12-23 11:09 ` Xu, Quan
2015-12-25 1:50 ` Tian, Kevin
2015-12-25 2:26 ` Xu, Quan
2015-12-25 1:53 ` Tian, Kevin
2015-12-25 2:04 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450859136-98482-3-git-send-email-quan.xu@intel.com \
--to=quan.xu@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=feng.wu@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).