xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: xen devel <xen-devel@lists.xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Yang Hongyang <hongyang.yang@easystack.cn>
Subject: [PATCH 1/5] remus: don't call stream_continue() when doing failover
Date: Wed, 30 Dec 2015 09:39:44 +0800	[thread overview]
Message-ID: <1451439588-25310-2-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1451439588-25310-1-git-send-email-wency@cn.fujitsu.com>

stream_continue() is used for migration to read emulator
xenstore data and emulator context. For remus, if we do
failover, we have read it in the checkpoint cycle, and
we only need to complete the stream.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 tools/libxl/libxl_stream_read.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/tools/libxl/libxl_stream_read.c b/tools/libxl/libxl_stream_read.c
index 258dec4..42c087f 100644
--- a/tools/libxl/libxl_stream_read.c
+++ b/tools/libxl/libxl_stream_read.c
@@ -758,6 +758,9 @@ void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void,
     libxl__stream_read_state *stream = &dcs->srs;
     STATE_AO_GC(dcs->ao);
 
+    /* convenience aliases */
+    const int checkpointed_stream = dcs->restore_params.checkpointed_stream;
+
     if (rc)
         goto err;
 
@@ -777,11 +780,16 @@ void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void,
      * If the stream is not still alive, we must not continue any work.
      */
     if (libxl__stream_read_inuse(stream)) {
-        /*
-         * Libxc has indicated that it is done with the stream.  Resume reading
-         * libxl records from it.
-         */
-        stream_continue(egc, stream);
+        if (checkpointed_stream) {
+            /* failover */
+            stream_complete(egc, stream, 0);
+        } else {
+            /*
+             * Libxc has indicated that it is done with the stream.
+             * Resume reading libxl records from it.
+             */
+            stream_continue(egc, stream);
+        }
     }
 }
 
-- 
2.5.0

  reply	other threads:[~2015-12-30  1:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30  1:39 [PATCH 0/5] migration/remus: bug fix and cleanup Wen Congyang
2015-12-30  1:39 ` Wen Congyang [this message]
2015-12-30 10:43   ` [PATCH 1/5] remus: don't call stream_continue() when doing failover Andrew Cooper
2015-12-30  1:39 ` [PATCH 2/5] remus: don't write xenstore data if it fails Wen Congyang
2015-12-30 10:47   ` Andrew Cooper
2015-12-31  1:00     ` Wen Congyang
2015-12-30  1:39 ` [PATCH 3/5] tools/libxc: don't send end record if remus fails Wen Congyang
2015-12-30 11:11   ` Andrew Cooper
2015-12-31  0:49     ` Wen Congyang
2015-12-30  1:39 ` [PATCH 4/5] tools/libxl: remove unused function libxl__domain_save_device_model() Wen Congyang
2015-12-30  1:39 ` [PATCH 5/5] Allow all user to create a file under the directory /var/lib/xen Wen Congyang
2015-12-30  4:11   ` Doug Goldstein
2015-12-30  5:25     ` Wen Congyang
2015-12-30 11:00       ` Andrew Cooper
2016-01-25 20:36         ` Konrad Rzeszutek Wilk
2016-01-26  0:00           ` Andrew Cooper
2016-01-26  9:30             ` Ian Campbell
2016-01-26 17:15               ` Stefano Stabellini
2016-01-27  9:48                 ` Ian Campbell
2015-12-30 10:38 ` [PATCH 0/5] migration/remus: bug fix and cleanup Andrew Cooper
2015-12-31  0:48   ` Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451439588-25310-2-git-send-email-wency@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=rshriram@cs.ubc.ca \
    --cc=xen-devel@lists.xen.org \
    --cc=xiecl.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).