From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Kevin Tian <kevin.tian@intel.com>
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
Keir Fraser <keir@xen.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: [PATCH v3 03/13] x86/hvm: Scale host TSC when setting/getting guest TSC
Date: Thu, 31 Dec 2015 11:03:30 +0800 [thread overview]
Message-ID: <1451531020-29964-4-git-send-email-haozhong.zhang@intel.com> (raw)
In-Reply-To: <1451531020-29964-1-git-send-email-haozhong.zhang@intel.com>
The existing hvm_[set|get]_guest_tsc_fixed() calculate the guest TSC by
adding the TSC offset to the host TSC. When the TSC scaling is enabled,
the host TSC should be scaled first. This patch adds the scaling logic
to those two functions.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
---
xen/arch/x86/hvm/hvm.c | 17 +++++++----------
xen/arch/x86/hvm/svm/svm.c | 12 ++++++++++++
xen/include/asm-x86/hvm/hvm.h | 2 ++
3 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 21470ec..3648a44 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -60,6 +60,7 @@
#include <asm/hvm/nestedhvm.h>
#include <asm/hvm/event.h>
#include <asm/hvm/vmx/vmx.h>
+#include <asm/hvm/svm/svm.h> /* for cpu_has_tsc_ratio */
#include <asm/altp2m.h>
#include <asm/mtrr.h>
#include <asm/apic.h>
@@ -310,13 +311,11 @@ void hvm_set_guest_tsc_fixed(struct vcpu *v, u64 guest_tsc, u64 at_tsc)
tsc = hvm_get_guest_time_fixed(v, at_tsc);
tsc = gtime_to_gtsc(v->domain, tsc);
}
- else if ( at_tsc )
- {
- tsc = at_tsc;
- }
else
{
- tsc = rdtsc();
+ tsc = at_tsc ?: rdtsc();
+ if ( cpu_has_tsc_ratio )
+ tsc = hvm_funcs.scale_tsc(v, tsc);
}
delta_tsc = guest_tsc - tsc;
@@ -344,13 +343,11 @@ u64 hvm_get_guest_tsc_fixed(struct vcpu *v, uint64_t at_tsc)
tsc = hvm_get_guest_time_fixed(v, at_tsc);
tsc = gtime_to_gtsc(v->domain, tsc);
}
- else if ( at_tsc )
- {
- tsc = at_tsc;
- }
else
{
- tsc = rdtsc();
+ tsc = at_tsc ?: rdtsc();
+ if ( cpu_has_tsc_ratio )
+ tsc = hvm_funcs.scale_tsc(v, tsc);
}
return tsc + v->arch.hvm_vcpu.cache_tsc_offset;
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index a66d854..c538a29 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -804,6 +804,16 @@ static uint64_t scale_tsc(uint64_t host_tsc, uint64_t ratio)
return scaled_host_tsc;
}
+static uint64_t svm_scale_tsc(struct vcpu *v, uint64_t tsc)
+{
+ struct domain *d = v->domain;
+
+ if ( !cpu_has_tsc_ratio || d->arch.vtsc )
+ return tsc;
+
+ return scale_tsc(tsc, vcpu_tsc_ratio(v));
+}
+
static uint64_t svm_get_tsc_offset(uint64_t host_tsc, uint64_t guest_tsc,
uint64_t ratio)
{
@@ -2272,6 +2282,8 @@ static struct hvm_function_table __initdata svm_function_table = {
.nhvm_vmcx_hap_enabled = nsvm_vmcb_hap_enabled,
.nhvm_intr_blocked = nsvm_intr_blocked,
.nhvm_hap_walk_L1_p2m = nsvm_hap_walk_L1_p2m,
+
+ .scale_tsc = svm_scale_tsc,
};
void svm_vmexit_handler(struct cpu_user_regs *regs)
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
index b9d893d..ba6259e 100644
--- a/xen/include/asm-x86/hvm/hvm.h
+++ b/xen/include/asm-x86/hvm/hvm.h
@@ -212,6 +212,8 @@ struct hvm_function_table {
void (*altp2m_vcpu_update_vmfunc_ve)(struct vcpu *v);
bool_t (*altp2m_vcpu_emulate_ve)(struct vcpu *v);
int (*altp2m_vcpu_emulate_vmfunc)(struct cpu_user_regs *regs);
+
+ uint64_t (*scale_tsc)(struct vcpu *v, uint64_t tsc);
};
extern struct hvm_function_table hvm_funcs;
--
2.4.8
next prev parent reply other threads:[~2015-12-31 3:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 3:03 [PATCH v3 00/13] Add VMX TSC scaling support Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 01/13] x86/time.c: Use correct guest TSC frequency in tsc_set_info() Haozhong Zhang
2016-01-04 17:44 ` Boris Ostrovsky
2015-12-31 3:03 ` [PATCH v3 02/13] x86/time.c: Use correct guest TSC frequency in tsc_get_info() Haozhong Zhang
2016-01-04 17:48 ` Boris Ostrovsky
2016-01-05 0:32 ` Haozhong Zhang
2016-01-08 9:05 ` Jan Beulich
2016-01-08 9:12 ` Haozhong Zhang
2015-12-31 3:03 ` Haozhong Zhang [this message]
2016-01-08 9:15 ` [PATCH v3 03/13] x86/hvm: Scale host TSC when setting/getting guest TSC Jan Beulich
2016-01-08 14:04 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 04/13] x86/time.c: Scale host TSC in pvclock properly Haozhong Zhang
2016-01-04 18:09 ` Boris Ostrovsky
2016-01-05 0:59 ` Haozhong Zhang
2016-01-05 16:15 ` Boris Ostrovsky
2016-01-06 0:56 ` Haozhong Zhang
2016-01-08 9:20 ` Jan Beulich
2016-01-08 13:22 ` Haozhong Zhang
2016-01-08 13:43 ` Jan Beulich
2016-01-08 13:50 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 05/13] svm: Remove redundant TSC scaling in svm_set_tsc_offset() Haozhong Zhang
2016-01-08 9:22 ` Jan Beulich
2016-01-08 13:24 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 06/13] x86/hvm: Collect information of TSC scaling ratio Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 07/13] x86: Add functions for 64-bit integer arithmetic Haozhong Zhang
2016-01-04 18:26 ` Boris Ostrovsky
2016-01-05 1:15 ` Haozhong Zhang
2016-01-05 16:21 ` Boris Ostrovsky
2016-01-08 9:34 ` Jan Beulich
2016-01-08 13:48 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 08/13] x86/hvm: Setup TSC scaling ratio Haozhong Zhang
2016-01-04 18:40 ` Boris Ostrovsky
2016-01-05 1:20 ` Haozhong Zhang
2016-01-08 9:44 ` Jan Beulich
2016-01-08 13:55 ` Haozhong Zhang
2016-01-08 14:04 ` Jan Beulich
2016-01-08 14:10 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 09/13] x86/hvm: Replace architecture TSC scaling by a common function Haozhong Zhang
2016-01-04 18:42 ` Boris Ostrovsky
2016-01-12 16:44 ` Jan Beulich
2015-12-31 3:03 ` [PATCH v3 10/13] x86/hvm: Move saving/loading vcpu's TSC to common code Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 11/13] x86/hvm: Detect TSC scaling through hvm_funcs Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 12/13] vmx: Add VMX RDTSC(P) scaling support Haozhong Zhang
2016-01-12 16:48 ` Jan Beulich
2016-01-14 4:52 ` Haozhong Zhang
2016-01-14 9:05 ` Jan Beulich
2016-01-14 9:47 ` Haozhong Zhang
2015-12-31 3:03 ` [PATCH v3 13/13] docs: Add descriptions of TSC scaling in xl.cfg and tscmode.txt Haozhong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451531020-29964-4-git-send-email-haozhong.zhang@intel.com \
--to=haozhong.zhang@intel.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).