Re: [xen-4.4-testing test] 66718: regressions - FAIL

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-12-21 at 10:16 -0700, Jan Beulich wrote:
> > > > On 21.12.15 at 18:01, <osstest-admin@xenproject.org> wrote:
> > flight 66718 xen-4.4-testing real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/66718/ 
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-amd64-prev              5 xen-build                 fail REGR.
> > vs. 66458
> >  build-i386-prev               5 xen-build                 fail REGR.
> > vs. 66458
> >  build-armhf                   5 xen-build                 fail REGR.
> > vs. 66458
> 
> Considering
> 
> libxlu_cfg_y.c: In function 'xlu__cfg_yyparse':
> libxlu_cfg_y.c:1311:50: error: 'scanner' undeclared (first use in this
> function)
>        yychar = yylex (&yylval, &yylloc, scanner);
>                                                   ^
> libxlu_cfg_y.c:1311:50: note: each undeclared identifier is reported only
> once for each function it appears in
> make[3]: *** [libxlu_cfg_y.o] Error 1
> 
> - was there any change to the ARM build environment?

osstest switched from using Debian 7.0 (Wheezy) to Debian 8 (Jessie) as the
base distro, which will have update the compiler etc.

I can't see why this would cause this kind of issue though, but I'm
somewhat hampered by the line numbers not matching and the amount of
ifdeffery in this auto generated file.

Since 4.5 looks ok perhaps one of the below is needed? In fact, yes, I'm
sure, since in the logs I now see:

/usr/bin/bison --output=libxlu_cfg_y.c libxlu_cfg_y.y
python gentypes.py libxl_types_internal.idl __libxl_types_internal.h __libxl_types_internal_json.h __libxl_types_internal.c
libxlu_cfg_y.y:34.1-13: warning: deprecated directive, use '%name-prefix' [-Wdeprecated]
 %name-prefix="xlu__cfg_yy"
 ^^^^^^^^^^^^^

which matches some of the keywords in 7ba4cdfadd4f3's commit message...

Ian.

$ git log origin/staging-4.4..origin/staging-4.5  -- tools/libxl/libxlu_cfg_y.c  
commit 7ba4cdfadd4f3c45d65ffe50e621759f458fedc0
Author: Ed Swierk <eswierk@skyportsystems.com>
Date:   Tue Jan 6 15:21:07 2015 +0000

    libxl: Fix building libxlu_cfg_y.y with bison 3.0
    
    - Use %lex-param instead of obsolete YYLEX_PARAM to override lex scanner
      parameter
    - Change deprecated %name-prefix= to %name-prefix
    
    Tested against bison 2.4.1 and 3.0.2.
    
    This is expected to sometimes (depending on timestamps and whether the
    bison input files are edited) break building on systems with ancient
    versions of bison.  Bison 2.4.1 is known to work and was released in
    December 2008.
    
    Also, consquentially, regenerate bison output files with bison
    1:2.5.dfsg-2.1 from Debian wheezy.
    
    Signed-off-by: Ed Swierk <eswierk@skyportsystems.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Tested-by: Wei Liu <wei.liu2@citrix.com>
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

commit dc92f1a781a160229e4935dc03040bc78712a828
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date:   Fri May 2 17:47:55 2014 +0100

    libxl: Rerun bison
    
    This updates libxlu_cfg_y.[ch] to code generated by bison from
    Debian wheezy (1:2.5.dfsg-2.1 i386).
    
    There should be no functional change since there is no change to the
    source file, but we will inherit bugfixes and behavioural changes from
    the new version of bison.  So this is more a matter of hope than
    knowledge.
    
    Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel