From: Ian Campbell <ian.campbell@citrix.com>
To: Meng Xu <xumengpanda@gmail.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
Tianyang Chen <tiche@seas.upenn.edu>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH 1/1] Improved RTDS scheduler
Date: Mon, 4 Jan 2016 14:04:26 +0000 [thread overview]
Message-ID: <1451916266.13361.110.camel@citrix.com> (raw)
In-Reply-To: <CAENZ-+n8rc8Q0erW+vt73ZywDt8gno4jcZ9qOnEW9uGft3nX5w@mail.gmail.com>
On Mon, 2016-01-04 at 21:48 +0800, Meng Xu wrote:
> > (In general single patches do not require a separate cover letter
> > unless
> > the required context contains a large amount of information which is
> > not
> > appropriate for the commit message of the actual change, I'll leave it
> > to
> > you and the scheduler maintainers to decide how much of your cover
> > letter
> > it would be appropriate to move to the commit message).
>
> The cover letter is supposed to explain the design idea of the
> improved RTDS scheduler so that reviewers could (potentially) save
> time in reviewing the patch, we think. :-)
> Probably, the commit message should be refined and self-contained?
If I were maintainer of this code I would likely ask that a bunch of the
information from the cover letter (i..e anything which would still be
relevant to a code archaeologist in 6 months or 10 years) was moved into
the commit message, but I'm not maintainer of this code.
Ian.
next prev parent reply other threads:[~2016-01-04 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 9:45 [PATCH 0/1] Improved RTDS scheduler Tianyang Chen
2015-12-31 9:45 ` [PATCH 1/1] " Tianyang Chen
2016-01-04 11:42 ` Ian Campbell
2016-01-04 13:48 ` Meng Xu
2016-01-04 14:04 ` Ian Campbell [this message]
2016-01-04 14:36 ` Dario Faggioli
2016-01-06 7:11 ` Tianyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451916266.13361.110.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=mengxu@cis.upenn.edu \
--cc=tiche@seas.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).