* [xen-4.4-testing test] 66583: regressions - FAIL
@ 2015-12-20 12:25 osstest service owner
2015-12-21 11:52 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: osstest service owner @ 2015-12-20 12:25 UTC (permalink / raw)
To: xen-devel, osstest-admin
flight 66583 xen-4.4-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/66583/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-prev 5 xen-build fail REGR. vs. 66458
build-i386-prev 5 xen-build fail REGR. vs. 66458
test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 66458
test-armhf-armhf-xl-credit2 15 guest-start/debian.repeat fail REGR. vs. 66458
test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 66458
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-xl-qemuu-win7-amd64 13 guest-localmigrate fail REGR. vs. 66458
test-armhf-armhf-xl-multivcpu 15 guest-start/debian.repeat fail like 66458
test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 66458
Tests which did not succeed, but are not blocking:
test-amd64-amd64-rumpuserxen-amd64 1 build-check(1) blocked n/a
test-amd64-i386-rumpuserxen-i386 1 build-check(1) blocked n/a
test-amd64-amd64-migrupgrade 1 build-check(1) blocked n/a
test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a
test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail never pass
build-amd64-rumpuserxen 6 xen-build fail never pass
build-i386-rumpuserxen 6 xen-build fail never pass
test-armhf-armhf-libvirt-raw 9 debian-di-install fail never pass
test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-install/l1/l2 fail never pass
test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass
test-armhf-armhf-xl-multivcpu 13 saverestore-support-check fail never pass
test-armhf-armhf-xl-multivcpu 12 migrate-support-check fail never pass
test-armhf-armhf-xl 12 migrate-support-check fail never pass
test-armhf-armhf-xl 13 saverestore-support-check fail never pass
test-armhf-armhf-libvirt 11 guest-start fail never pass
test-amd64-i386-libvirt 12 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 12 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 13 saverestore-support-check fail never pass
test-amd64-amd64-libvirt-vhd 11 migrate-support-check fail never pass
test-armhf-armhf-xl-cubietruck 12 migrate-support-check fail never pass
test-armhf-armhf-xl-cubietruck 13 saverestore-support-check fail never pass
test-amd64-amd64-libvirt 12 migrate-support-check fail never pass
test-armhf-armhf-xl-credit2 13 saverestore-support-check fail never pass
test-armhf-armhf-xl-credit2 12 migrate-support-check fail never pass
test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail never pass
test-armhf-armhf-xl-vhd 9 debian-di-install fail never pass
test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail never pass
test-amd64-i386-xend-qemut-winxpsp3 20 leak-check/check fail never pass
version targeted for testing:
xen fd4db045339863c901e887fe35fe958ce766351e
baseline version:
xen d0b73c9bf21f9199401a36eeda7ba0a4412aad6d
Last test of basis 66458 2015-12-17 09:42:47 Z 3 days
Failing since 66520 2015-12-18 10:37:08 Z 2 days 2 attempts
Testing same since 66583 2015-12-19 06:03:35 Z 1 days 1 attempts
------------------------------------------------------------
People who touched revisions under test:
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jan Beulich <jbeulich@suse.com>
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
jobs:
build-amd64-xend pass
build-i386-xend pass
build-amd64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-armhf-libvirt pass
build-i386-libvirt pass
build-amd64-prev fail
build-i386-prev fail
build-amd64-pvops pass
build-armhf-pvops pass
build-i386-pvops pass
build-amd64-rumpuserxen fail
build-i386-rumpuserxen fail
test-amd64-amd64-xl pass
test-armhf-armhf-xl pass
test-amd64-i386-xl pass
test-amd64-amd64-qemuu-nested-amd fail
test-amd64-i386-qemut-rhel6hvm-amd pass
test-amd64-i386-qemuu-rhel6hvm-amd pass
test-amd64-amd64-xl-qemut-debianhvm-amd64 pass
test-amd64-i386-xl-qemut-debianhvm-amd64 pass
test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-freebsd10-amd64 pass
test-amd64-amd64-xl-qemuu-ovmf-amd64 fail
test-amd64-i386-xl-qemuu-ovmf-amd64 fail
test-amd64-amd64-rumpuserxen-amd64 blocked
test-amd64-amd64-xl-qemut-win7-amd64 fail
test-amd64-i386-xl-qemut-win7-amd64 fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-i386-xl-qemuu-win7-amd64 fail
test-armhf-armhf-xl-arndale pass
test-amd64-amd64-xl-credit2 pass
test-armhf-armhf-xl-credit2 fail
test-armhf-armhf-xl-cubietruck pass
test-amd64-i386-freebsd10-i386 pass
test-amd64-i386-rumpuserxen-i386 blocked
test-amd64-amd64-qemuu-nested-intel fail
test-amd64-i386-qemut-rhel6hvm-intel pass
test-amd64-i386-qemuu-rhel6hvm-intel pass
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt fail
test-amd64-i386-libvirt pass
test-amd64-amd64-migrupgrade blocked
test-amd64-i386-migrupgrade blocked
test-amd64-amd64-xl-multivcpu pass
test-armhf-armhf-xl-multivcpu fail
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-amd64-amd64-libvirt-pair pass
test-amd64-i386-libvirt-pair pass
test-amd64-amd64-pv pass
test-amd64-i386-pv pass
test-amd64-amd64-amd64-pvgrub pass
test-amd64-amd64-i386-pvgrub pass
test-amd64-amd64-pygrub pass
test-armhf-armhf-libvirt-qcow2 fail
test-amd64-amd64-xl-qcow2 pass
test-armhf-armhf-libvirt-raw fail
test-amd64-i386-xl-raw pass
test-amd64-i386-xl-qemut-winxpsp3-vcpus1 pass
test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 pass
test-amd64-amd64-libvirt-vhd pass
test-armhf-armhf-xl-vhd fail
test-amd64-i386-xend-qemut-winxpsp3 fail
test-amd64-amd64-xl-qemut-winxpsp3 pass
test-amd64-amd64-xl-qemuu-winxpsp3 pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit fd4db045339863c901e887fe35fe958ce766351e
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Fri Dec 18 14:58:40 2015 +0000
QEMU_TAG update
commit 4dacb5d7429913430895fe38cb58308ea4fa4a05
Author: Jan Beulich <jbeulich@suse.com>
Date: Thu Dec 17 14:31:28 2015 +0100
x86/HVM: avoid reading ioreq state more than once
Otherwise, especially when the compiler chooses to translate the
switch() to a jump table, unpredictable behavior (and in the jump table
case arbitrary code execution) can result.
This is XSA-166.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
master commit: b452430a4cdfc801fa4bc391aed7522365e1deb6
master date: 2015-12-17 14:22:46 +0100
commit 52a5c0bf5350f045810d159af0c06305dd9d517f
Author: Jan Beulich <jbeulich@suse.com>
Date: Thu Dec 17 14:30:57 2015 +0100
x86: don't leak ST(n)/XMMn values to domains first using them
FNINIT doesn't alter these registers, and hence using it is
insufficient to initialize a guest's initial state.
This is CVE-2015-8555 / XSA-165.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
master commit: 81818b3f277544535974204f8d840da86fa8a44f
master date: 2015-12-17 14:22:13 +0100
========================================
commit c51f20baba0bc01e7e3a3a16e72be9a0ed6cb734
Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Date: Fri Nov 20 10:56:00 2015 -0500
blkif: Avoid double access to src->nr_segments
src is stored in shared memory and src->nr_segments is dereferenced
twice at the end of the function. If a compiler decides to compile this
into two separate memory accesses then the size limitation could be
bypassed.
Fix it by removing the double access to src->nr_segments.
This is part of XSA-155.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
commit bc468fe34e146026854242676635d9435dab5c0d
Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Date: Fri Nov 20 10:37:08 2015 -0500
xenfb: avoid reading twice the same fields from the shared page
Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.
This is part of XSA-155.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2015-12-20 12:25 [xen-4.4-testing test] 66583: regressions - FAIL osstest service owner
@ 2015-12-21 11:52 ` Jan Beulich
2015-12-22 13:55 ` Stefano Stabellini
0 siblings, 1 reply; 11+ messages in thread
From: Jan Beulich @ 2015-12-21 11:52 UTC (permalink / raw)
To: Ian Jackson, Stefano Stabellini; +Cc: xen-devel, osstest-admin
>>> On 20.12.15 at 13:25, <osstest-admin@xenproject.org> wrote:
> flight 66583 xen-4.4-testing real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/66583/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-amd64-prev 5 xen-build fail REGR. vs. 66458
> build-i386-prev 5 xen-build fail REGR. vs. 66458
Ian, Stefano,
is one of you two looking into this?
block-qcow.c: In function 'get_cluster_offset':
block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
memcpy(tmp_ptr, l1_ptr, 4096);
^
block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (write(s->fd, tmp_ptr2, 4096) != 4096) {
^
cc1: all warnings being treated as errors
/home/osstest/build.66583.build-amd64-prev/xen/tools/blktap/drivers/../../../tools/Rules.mk:89: recipe for target 'block-qcow.o' failed
make[5]: *** [block-qcow.o] Error 1
Thanks, Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2015-12-21 11:52 ` Jan Beulich
@ 2015-12-22 13:55 ` Stefano Stabellini
2015-12-22 14:24 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: Stefano Stabellini @ 2015-12-22 13:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Ian Jackson, osstest-admin, Stefano Stabellini
On Mon, 21 Dec 2015, Jan Beulich wrote:
> >>> On 20.12.15 at 13:25, <osstest-admin@xenproject.org> wrote:
> > flight 66583 xen-4.4-testing real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/66583/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> > build-amd64-prev 5 xen-build fail REGR. vs. 66458
> > build-i386-prev 5 xen-build fail REGR. vs. 66458
>
> Ian, Stefano,
>
> is one of you two looking into this?
>
> block-qcow.c: In function 'get_cluster_offset':
> block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> memcpy(tmp_ptr, l1_ptr, 4096);
> ^
> block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (write(s->fd, tmp_ptr2, 4096) != 4096) {
> ^
> cc1: all warnings being treated as errors
> /home/osstest/build.66583.build-amd64-prev/xen/tools/blktap/drivers/../../../tools/Rules.mk:89: recipe for target 'block-qcow.o' failed
> make[5]: *** [block-qcow.o] Error 1
What does build-amd64-prev means? I cannot find the explanation of the
test anywhere.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2015-12-22 13:55 ` Stefano Stabellini
@ 2015-12-22 14:24 ` Jan Beulich
2015-12-22 14:40 ` Stefano Stabellini
0 siblings, 1 reply; 11+ messages in thread
From: Jan Beulich @ 2015-12-22 14:24 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel, Ian Jackson, osstest-admin
>>> On 22.12.15 at 14:55, <stefano.stabellini@eu.citrix.com> wrote:
> On Mon, 21 Dec 2015, Jan Beulich wrote:
>> >>> On 20.12.15 at 13:25, <osstest-admin@xenproject.org> wrote:
>> > flight 66583 xen-4.4-testing real [real]
>> > http://logs.test-lab.xenproject.org/osstest/logs/66583/
>> >
>> > Regressions :-(
>> >
>> > Tests which did not succeed and are blocking,
>> > including tests which could not be run:
>> > build-amd64-prev 5 xen-build fail REGR. vs.
> 66458
>> > build-i386-prev 5 xen-build fail REGR. vs.
> 66458
>>
>> Ian, Stefano,
>>
>> is one of you two looking into this?
>>
>> block-qcow.c: In function 'get_cluster_offset':
>> block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>> memcpy(tmp_ptr, l1_ptr, 4096);
>> ^
>> block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>> if (write(s->fd, tmp_ptr2, 4096) != 4096) {
>> ^
>> cc1: all warnings being treated as errors
>>
> /home/osstest/build.66583.build-amd64-prev/xen/tools/blktap/drivers/../../../to
> ols/Rules.mk:89: recipe for target 'block-qcow.o' failed
>> make[5]: *** [block-qcow.o] Error 1
>
> What does build-amd64-prev means? I cannot find the explanation of the
> test anywhere.
Iiuc it's the build pf the previous version, needed to test n-1 -> n
migration. I.e. (in line with the respective 4.3 failure) it indicates
that 4.3's qemu doesn't build.
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2015-12-22 14:24 ` Jan Beulich
@ 2015-12-22 14:40 ` Stefano Stabellini
2016-01-04 10:09 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Stefano Stabellini @ 2015-12-22 14:40 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Ian Jackson, osstest-admin, Stefano Stabellini
On Tue, 22 Dec 2015, Jan Beulich wrote:
> >>> On 22.12.15 at 14:55, <stefano.stabellini@eu.citrix.com> wrote:
> > On Mon, 21 Dec 2015, Jan Beulich wrote:
> >> >>> On 20.12.15 at 13:25, <osstest-admin@xenproject.org> wrote:
> >> > flight 66583 xen-4.4-testing real [real]
> >> > http://logs.test-lab.xenproject.org/osstest/logs/66583/
> >> >
> >> > Regressions :-(
> >> >
> >> > Tests which did not succeed and are blocking,
> >> > including tests which could not be run:
> >> > build-amd64-prev 5 xen-build fail REGR. vs.
> > 66458
> >> > build-i386-prev 5 xen-build fail REGR. vs.
> > 66458
> >>
> >> Ian, Stefano,
> >>
> >> is one of you two looking into this?
> >>
> >> block-qcow.c: In function 'get_cluster_offset':
> >> block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> >> memcpy(tmp_ptr, l1_ptr, 4096);
> >> ^
> >> block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> >> if (write(s->fd, tmp_ptr2, 4096) != 4096) {
> >> ^
> >> cc1: all warnings being treated as errors
> >>
> > /home/osstest/build.66583.build-amd64-prev/xen/tools/blktap/drivers/../../../to
> > ols/Rules.mk:89: recipe for target 'block-qcow.o' failed
> >> make[5]: *** [block-qcow.o] Error 1
> >
> > What does build-amd64-prev means? I cannot find the explanation of the
> > test anywhere.
>
> Iiuc it's the build pf the previous version, needed to test n-1 -> n
> migration. I.e. (in line with the respective 4.3 failure) it indicates
> that 4.3's qemu doesn't build.
Thanks for the explanation, it was very helpful.
>From the logs what is not building is actually tools/blktap, not QEMU
though, but I cannot reproduce the failure.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2015-12-22 14:40 ` Stefano Stabellini
@ 2016-01-04 10:09 ` Ian Campbell
2016-01-04 14:54 ` Ian Jackson
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2016-01-04 10:09 UTC (permalink / raw)
To: Stefano Stabellini, Jan Beulich, Ian Jackson; +Cc: xen-devel, osstest-admin
On Tue, 2015-12-22 at 14:40 +0000, Stefano Stabellini wrote:
> On Tue, 22 Dec 2015, Jan Beulich wrote:
> > > > > On 22.12.15 at 14:55, <stefano.stabellini@eu.citrix.com> wrote:
> > > On Mon, 21 Dec 2015, Jan Beulich wrote:
> > > > > > > On 20.12.15 at 13:25, <osstest-admin@xenproject.org> wrote:
> > > > > flight 66583 xen-4.4-testing real [real]
> > > > > http://logs.test-lab.xenproject.org/osstest/logs/66583/
> > > > >
> > > > > Regressions :-(
> > > > >
> > > > > Tests which did not succeed and are blocking,
> > > > > including tests which could not be run:
> > > > > build-amd64-prev 5 xen-build fail
> > > > > REGR. vs.
> > > 66458
> > > > > build-i386-prev 5 xen-build fail
> > > > > REGR. vs.
> > > 66458
> > > >
> > > > Ian, Stefano,
> > > >
> > > > is one of you two looking into this?
> > > >
> > > > block-qcow.c: In function 'get_cluster_offset':
> > > > block-qcow.c:444:3: error: 'tmp_ptr' may be used uninitialized in
> > > > this
> > > function [-Werror=maybe-uninitialized]
> > > > memcpy(tmp_ptr, l1_ptr, 4096);
> > > > ^
> > > > block-qcow.c:619:7: error: 'tmp_ptr2' may be used uninitialized in
> > > > this
> > > function [-Werror=maybe-uninitialized]
> > > > if (write(s->fd, tmp_ptr2, 4096) != 4096) {
> > > > ^
> > > > cc1: all warnings being treated as errors
> > > >
> > > /home/osstest/build.66583.build-amd64-
> > > prev/xen/tools/blktap/drivers/../../../to
> > > ols/Rules.mk:89: recipe for target 'block-qcow.o' failed
> > > > make[5]: *** [block-qcow.o] Error 1
> > >
> > > What does build-amd64-prev means? I cannot find the explanation of
> > > the
> > > test anywhere.
> >
> > Iiuc it's the build pf the previous version, needed to test n-1 -> n
> > migration. I.e. (in line with the respective 4.3 failure) it indicates
> > that 4.3's qemu doesn't build.
>
> Thanks for the explanation, it was very helpful.
>
> From the logs what is not building is actually tools/blktap, not QEMU
> though, but I cannot reproduce the failure.
I think we want to backport:
commit 345e44a85d71a1a910385f33c7f1ba3683026d18
Author: Dario Faggioli <dario.faggioli@citrix.com>
Date: Fri Jun 20 16:09:00 2014 +0200
blktap2: Fix two 'maybe uninitialized' variables
for which gcc 4.9.0 complains about, like this:
block-qcow.c: In function `get_cluster_offset':
block-qcow.c:431:3: error: `tmp_ptr' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
memcpy(tmp_ptr, l1_ptr, 4096);
^
block-qcow.c:606:7: error: `tmp_ptr2' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
if (write(s->fd, tmp_ptr2, 4096) != 4096) {
^
cc1: all warnings being treated as errors
/home/dario/Sources/xen/xen/xen.git/tools/blktap2/drivers/../../../tools/Rules.mk:89:
recipe for target 'block-qcow.o' failed
make[5]: *** [block-qcow.o] Error 1
The proper behavior is to return upon allocation failure.
About what to return, 0 seems the best option, looking
at both the function and the call sites.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
(this will have been exposed by the update to Jessie's compiler)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2016-01-04 10:09 ` Ian Campbell
@ 2016-01-04 14:54 ` Ian Jackson
2016-01-04 15:03 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Ian Jackson @ 2016-01-04 14:54 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, osstest-admin, Jan Beulich, Stefano Stabellini
Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583: regressions - FAIL"):
> I think we want to backport:
>
> commit 345e44a85d71a1a910385f33c7f1ba3683026d18
> Author: Dario Faggioli <dario.faggioli@citrix.com>
> Date: Fri Jun 20 16:09:00 2014 +0200
This is already in stable-4.4, as 5e39eb05, and has been since June.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2016-01-04 14:54 ` Ian Jackson
@ 2016-01-04 15:03 ` Ian Campbell
2016-01-04 15:15 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2016-01-04 15:03 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, osstest-admin, Jan Beulich, Stefano Stabellini
On Mon, 2016-01-04 at 14:54 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583:
> regressions - FAIL"):
> > I think we want to backport:
> >
> > commit 345e44a85d71a1a910385f33c7f1ba3683026d18
> > Author: Dario Faggioli <dario.faggioli@citrix.com>
> > Date: Fri Jun 20 16:09:00 2014 +0200
>
> This is already in stable-4.4, as 5e39eb05, and has been since June.
This failure is in build-*-prev, i.e. the backport needs to be to 4.3 (and
presumably earlier). Sorry for not making that clear.
But it is already there as c591613f8c62, also from June.
So now I am rather perplexed by the build failures, which look identical to
the ones in the commit message, modulo some line number skew.
http://logs.test-lab.xenproject.org/osstest/logs/66583/build-amd64-prev/5.ts-xen-build.log
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2016-01-04 15:03 ` Ian Campbell
@ 2016-01-04 15:15 ` Ian Campbell
2016-01-04 15:22 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2016-01-04 15:15 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, osstest-admin, Jan Beulich, Stefano Stabellini
On Mon, 2016-01-04 at 15:03 +0000, Ian Campbell wrote:
> On Mon, 2016-01-04 at 14:54 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583:
> > regressions - FAIL"):
> > > I think we want to backport:
> > >
> > > commit 345e44a85d71a1a910385f33c7f1ba3683026d18
> > > Author: Dario Faggioli <dario.faggioli@citrix.com>
> > > Date: Fri Jun 20 16:09:00 2014 +0200
> >
> > This is already in stable-4.4, as 5e39eb05, and has been since June.
>
> This failure is in build-*-prev, i.e. the backport needs to be to 4.3
> (and
> presumably earlier). Sorry for not making that clear.
>
> But it is already there as c591613f8c62, also from June.
>
> So now I am rather perplexed by the build failures, which look identical
> to
> the ones in the commit message, modulo some line number skew.
>
> http://logs.test-lab.xenproject.org/osstest/logs/66583/build-amd64-
> prev/5.ts-xen-build.log
FYI (and obviously) this also happened to the proper build jobs in 66638
which was a xen-4.3-testing flight. It was building 0574a773238f and:
$ git diff 0574a773238f origin/staging -- tools/blktap2/drivers/block-qcow.c
$
Where origin/staging is 8e4d18e113c9 and flight 67053 built that just fine.
So, wtf...
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2016-01-04 15:15 ` Ian Campbell
@ 2016-01-04 15:22 ` Ian Campbell
2016-01-06 11:41 ` Ian Jackson
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2016-01-04 15:22 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, osstest-admin, Jan Beulich, Stefano Stabellini
On Mon, 2016-01-04 at 15:15 +0000, Ian Campbell wrote:
> On Mon, 2016-01-04 at 15:03 +0000, Ian Campbell wrote:
> > On Mon, 2016-01-04 at 14:54 +0000, Ian Jackson wrote:
> > > Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583:
> > > regressions - FAIL"):
> > > > I think we want to backport:
> > > >
> > > > commit 345e44a85d71a1a910385f33c7f1ba3683026d18
> > > > Author: Dario Faggioli <dario.faggioli@citrix.com>
> > > > Date: Fri Jun 20 16:09:00 2014 +0200
> > >
> > > This is already in stable-4.4, as 5e39eb05, and has been since June.
> >
> > This failure is in build-*-prev, i.e. the backport needs to be to 4.3
> > (and
> > presumably earlier). Sorry for not making that clear.
> >
> > But it is already there as c591613f8c62, also from June.
> >
> > So now I am rather perplexed by the build failures, which look
> > identical
> > to
> > the ones in the commit message, modulo some line number skew.
> >
> > http://logs.test-lab.xenproject.org/osstest/logs/66583/build-amd64-
> > prev/5.ts-xen-build.log
>
> FYI (and obviously) this also happened to the proper build jobs in 66638
> which was a xen-4.3-testing flight. It was building 0574a773238f and:
>
> $ git diff 0574a773238f origin/staging -- tools/blktap2/drivers/block-
> qcow.c
> $
>
> Where origin/staging is 8e4d18e113c9 and flight 67053 built that just
> fine.
>
> So, wtf...
Aha, this failure is in tools/blktap/drivers/block-qcow.c and not
tools/blktap2/drivers/block-qcow.c.
345e44a85d71 was writing after blktap1 was remove from the tree so
backporting it wouldn't have helped.
$ git show 345e44a85d71a | patch tools/blktap/drivers/block-qcow.c
patching file tools/blktap/drivers/block-qcow.c
Hunk #1 succeeded at 440 (offset 13 lines).
Hunk #2 succeeded at 614 (offset 13 lines).
$
Seems like the way to go for all branches which still have blktap1 (4.5 and
back, although it was disabled by default in 76c66c689b85 which was in
4.4.0-rc1.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-4.4-testing test] 66583: regressions - FAIL
2016-01-04 15:22 ` Ian Campbell
@ 2016-01-06 11:41 ` Ian Jackson
0 siblings, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2016-01-06 11:41 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, osstest-admin, Jan Beulich, Stefano Stabellini
Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583: regressions - FAIL"):
> Aha, this failure is in tools/blktap/drivers/block-qcow.c and not
> tools/blktap2/drivers/block-qcow.c.
Well spotted.
> 345e44a85d71 was writing after blktap1 was remove from the tree so
> backporting it wouldn't have helped.
Right.
> $ git show 345e44a85d71a | patch tools/blktap/drivers/block-qcow.c
> patching file tools/blktap/drivers/block-qcow.c
> Hunk #1 succeeded at 440 (offset 13 lines).
> Hunk #2 succeeded at 614 (offset 13 lines).
> $
>
> Seems like the way to go for all branches which still have blktap1 (4.5 and
> back, although it was disabled by default in 76c66c689b85 which was in
> 4.4.0-rc1.
I have done roughly this, to 4.3-4.5 inclusive.
Ian.
commit a64bfae49ae845ba4cb8cb6923fa08c41439872a
Author: Dario Faggioli <dario.faggioli@citrix.com>
Date: Fri Jun 20 16:09:00 2014 +0200
blktap: Fix two 'maybe uninitialized' variables
[ Cross-ported to blktap1 from 345e44a85d71a
"blktap2: Fix two 'maybe uninitialized' variables" -iwj;
Remainder of commit message is from blktap2's version. ]
for which gcc 4.9.0 complains about, like this:
block-qcow.c: In function `get_cluster_offset':
block-qcow.c:431:3: error: `tmp_ptr' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
memcpy(tmp_ptr, l1_ptr, 4096);
^
block-qcow.c:606:7: error: `tmp_ptr2' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
if (write(s->fd, tmp_ptr2, 4096) != 4096) {
^
cc1: all warnings being treated as errors
/home/dario/Sources/xen/xen/xen.git/tools/blktap2/drivers/../../../tools/Rules.mk:89:
recipe for target 'block-qcow.o' failed
make[5]: *** [block-qcow.o] Error 1
The proper behavior is to return upon allocation failure.
About what to return, 0 seems the best option, looking
at both the function and the call sites.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Backport-requested-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
(cherry picked from commit 845e8c1653242bbd9b9de5a081182db0f3f39054)
(cherry picked from commit e003d429d8c63523df40663b4586c572ce796659)
diff --git a/tools/blktap/drivers/block-qcow.c b/tools/blktap/drivers/block-qcow.c
index 0e4e9cf..8fb6023 100644
--- a/tools/blktap/drivers/block-qcow.c
+++ b/tools/blktap/drivers/block-qcow.c
@@ -440,6 +440,7 @@ static uint64_t get_cluster_offset(struct tdqcow_state *s,
if (posix_memalign((void **)&tmp_ptr, 4096, 4096) != 0) {
DPRINTF("ERROR allocating memory for L1 table\n");
+ return 0;
}
memcpy(tmp_ptr, l1_ptr, 4096);
@@ -613,6 +614,7 @@ found:
if (posix_memalign((void **)&tmp_ptr2, 4096, 4096) != 0) {
DPRINTF("ERROR allocating memory for L1 table\n");
+ return 0;
}
memcpy(tmp_ptr2, l2_ptr, 4096);
lseek(s->fd, l2_offset + (l2_sector << 12), SEEK_SET);
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-01-06 11:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-20 12:25 [xen-4.4-testing test] 66583: regressions - FAIL osstest service owner
2015-12-21 11:52 ` Jan Beulich
2015-12-22 13:55 ` Stefano Stabellini
2015-12-22 14:24 ` Jan Beulich
2015-12-22 14:40 ` Stefano Stabellini
2016-01-04 10:09 ` Ian Campbell
2016-01-04 14:54 ` Ian Jackson
2016-01-04 15:03 ` Ian Campbell
2016-01-04 15:15 ` Ian Campbell
2016-01-04 15:22 ` Ian Campbell
2016-01-06 11:41 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).