From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: wei.liu2@citrix.com, 805508@bugs.debian.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: allow configure time choice of libexec subdirectory.
Date: Tue, 5 Jan 2016 14:52:27 +0000 [thread overview]
Message-ID: <1452005547.13361.298.camel@citrix.com> (raw)
In-Reply-To: <22154.42262.126829.326566@mariner.uk.xensource.com>
On Mon, 2016-01-04 at 17:00 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH] tools: allow configure time choice of
> libexec subdirectory."):
> > I somehow slipped a stray ` in there and didn't notice, sorry.
>
> This looks like a reasonable change aside from that but we should
> definitely do some build tests at commit time.
Right, my pre-push scripting involves a build on all architectures and a
diff of the lists of installed files, I think that would have caught any
remaining issues (and didn't).
> With the stray ` removed:
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Applied, thanks (and to Doug).
prev parent reply other threads:[~2016-01-05 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 15:06 [PATCH] tools: allow configure time choice of libexec subdirectory Ian Campbell
2015-12-16 15:33 ` Ian Campbell
[not found] ` <1450280017.4053.61.camel@citrix.com>
2015-12-18 19:55 ` Doug Goldstein
2016-01-04 17:00 ` Ian Jackson
2016-01-05 14:52 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452005547.13361.298.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=805508@bugs.debian.org \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).