xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [OSSTEST PATCH v2] support XSM/FLASK via Kconfig
Date: Wed, 6 Jan 2016 10:25:50 +0000	[thread overview]
Message-ID: <1452075950.7292.12.camel@citrix.com> (raw)
In-Reply-To: <1452057924-17029-1-git-send-email-cardoe@cardoe.com>

On Tue, 2016-01-05 at 23:25 -0600, Doug Goldstein wrote:
> In antcipation of XSM and FLASK migrating to Kconfig add support for
> building them via Kconfig or the existing mechanism.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> Still untested but visually looks correct.
> 
> Changes since v2:
> - Support Xen versions prior to Kconfig being integrated

Do we not need the gate on the first hunk as well? 

A non-Kconfig aware would ignore the xen/.config but osstest will collect
it later on and that might confuse folks reading the logs.

Such a Xen also won't have a .gitignore entry for xen/.config, so various
git commands might show this tree as dirty. I don't think osstest would
rely on such though, so maybe this doesn't really matter. I don't think
xen/scripts/scmversion adds -dirty in this case either.

> ---
>  ts-xen-build | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/ts-xen-build b/ts-xen-build
> index 80b1faa..8dde146 100755
> --- a/ts-xen-build
> +++ b/ts-xen-build
> @@ -55,6 +55,8 @@ sub checkout () {
>  	echo >>.config KERNELS=''
>  END
>                 (nonempty($r{enable_xsm}) ? <<END : '').
> +	echo >>xen/.config CONFIG_XSM='${build_xsm}'
> +	echo >>xen/.config CONFIG_FLASK='${build_xsm}'
>  	echo >>.config XSM_ENABLE='${build_xsm}'
>  END
>                 (nonempty($r{tree_qemu}) ? <<END : '').
> @@ -126,6 +128,9 @@ END
>  END
>  #/;
>      buildcmd_stamped_logged(9000, 'build', '',<<END,'');
> +            if test -f xen/Kconfig; then
> +                $make_prefix make -C xen olddefconfig
> +            fi
>              $make_prefix make $makeflags @ARGV
>  END
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-01-06 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  5:25 [OSSTEST PATCH v2] support XSM/FLASK via Kconfig Doug Goldstein
2016-01-06 10:25 ` Ian Campbell [this message]
2016-01-06 17:21   ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452075950.7292.12.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).