From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST] sg-report-job-history: alternate color of osstest column only when it changes
Date: Wed, 6 Jan 2016 11:08:43 +0000 [thread overview]
Message-ID: <1452078523-19830-1-git-send-email-ian.campbell@citrix.com> (raw)
Currently the bgcolor of the osstest column alternates on each line,
rather than only when it changes as the other revision columns do.
A given flight might touch multiple osstest revisions (although in
practice they rarely do) but it seems reasonable to simply consider
any change as a change.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
sg-report-job-history | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sg-report-job-history b/sg-report-job-history
index 0e2a3f9..e2e5806 100755
--- a/sg-report-job-history
+++ b/sg-report-job-history
@@ -234,6 +234,7 @@ END
my @last_revs;
my @alt_revs;
my $alt_hosts;
+ my $alt_osstest;
foreach my $r (@test_rows) {
my $altcolour= report_altcolour($alternate);
print H "<tr $altcolour>";
@@ -254,16 +255,15 @@ END
my $hosts_colour = report_altchangecolour(\$alt_hosts, $hosts);
print H "<td $hosts_colour>".encode_entities($hosts)."</td>\n";
$osstestverq->execute($r->{Flight}{flight});
- print H
- "<td>",
- (join ' ',
+ my $osstestrevs = join ' ',
map {
$_ = $_->{harness};
s/^([0-9a-f]{12})[0-9a-f]+\b/$1/;
"<kbd>".encode_entities($_)."</kbd>";
}
- @{ $osstestverq->fetchall_arrayref({}) }),
- "</td>\n";
+ @{ $osstestverq->fetchall_arrayref({}) };
+ my $osstest_colour = report_altchangecolour(\$alt_osstest, $osstestrevs);
+ print H "<td $osstest_colour>$osstestrevs</td>\n";
foreach my $i (0..$#rev_grid_cols) {
my $v= $r->{Revisions}[$i];
my $rev_colour = report_altchangecolour(\$alt_revs[$i], $v);
--
2.6.1
next reply other threads:[~2016-01-06 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 11:08 Ian Campbell [this message]
2016-01-19 11:38 ` [PATCH OSSTEST] sg-report-job-history: alternate color of osstest column only when it changes Ian Campbell
2016-01-19 18:28 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452078523-19830-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).