From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v3 05/11] igd:
 TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize
Date: Wed, 06 Jan 2016 16:45:01 +0100
Message-ID: <1452095101.6096.55.camel@redhat.com>
References: <1451994098-6972-1-git-send-email-kraxel@redhat.com>
	<1451994098-6972-6-git-send-email-kraxel@redhat.com>
	<alpine.DEB.2.02.1601061441080.31111@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <alpine.DEB.2.02.1601061441080.31111@kaball.uk.xensource.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: igvt-g@ml01.01.org, xen-devel@lists.xensource.com, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, Cao jin <caoj.fnst@cn.fujitsu.com>, vfio-users@redhat.com
List-Id: xen-devel@lists.xenproject.org

> > =20
> > +static void (*i440fx_realize)(PCIDevice *pci_dev, Error **errp);
> >  static void igd_pt_i440fx_realize(PCIDevice *pci_dev, Error **errp)
> >  {
> > +    Error *err =3D NULL;
> >      uint32_t val =3D 0;
> >      int rc, i, num;
> >      int pos, len;
>=20
> Can't we get the parent PCIDeviceClass realize function from pci_dev? So
> that we don't have to introduce i440fx_realize?

I don't think so ...

> > =20
> > +    i440fx_realize =3D k->realize;
> >      k->realize =3D igd_pt_i440fx_realize;

... because we are overriding it right here.

cheers,
  Gerd