Re: [PATCH v2 02/13] libxc: support new xenstore domain flag in libxc

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2016-01-07 at 07:08 +0100, Juergen Gross wrote:
> On 06/01/16 16:52, Ian Campbell wrote:
> > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
> > > Support the xenstore domain flag for obtaining domain info.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > ---
> > >  tools/libxc/include/xenctrl.h |  2 +-
> > >  tools/libxc/xc_domain.c       | 17 +++++++++--------
> > >  2 files changed, 10 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/tools/libxc/include/xenctrl.h
> > > b/tools/libxc/include/xenctrl.h
> > > index 01a6dda..45d8ff6 100644
> > > --- a/tools/libxc/include/xenctrl.h
> > > +++ b/tools/libxc/include/xenctrl.h
> > > @@ -456,7 +456,7 @@ typedef struct xc_dominfo {
> > >      uint32_t      ssidref;
> > >      unsigned int  dying:1, crashed:1, shutdown:1,
> > >                    paused:1, blocked:1, running:1,
> > > -                  hvm:1, debugged:1, pvh:1;
> > > +                  hvm:1, debugged:1, pvh:1, xs_domain:1;
> > 
> > All the other flags omit the _domain/_guest since it is implicit in the
> > context I think.
> > 
> > "xs" would be ok, so would "xenstore" or "xenstored" I think.
> > 
> > You might want to consider similar arguments for DOMINF and the create
> > flag, or you might want to argue that this field should be xs_domain for
> > consistency with those.
> 
> In case there are no objections from others, I'll go with "xenstore".

Sounds good to me.

> > 
> > Apart from what colour to paint the shed to code looks trivially
> > correct.
> 
> Can I take this as an "Ack"?

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel