From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 11/13] tools: split up xen-init-dom0.c Date: Thu, 7 Jan 2016 10:26:32 +0000 Message-ID: <1452162392.21055.165.camel@citrix.com> References: <1450444471-6454-1-git-send-email-jgross@suse.com> <1450444471-6454-12-git-send-email-jgross@suse.com> <1452097570.21055.109.camel@citrix.com> <20160106163312.GN27789@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160106163312.GN27789@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Juergen Gross , dgdegra@tycho.nsa.gov, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2016-01-06 at 16:33 +0000, Wei Liu wrote: > On Wed, Jan 06, 2016 at 04:26:10PM +0000, Ian Campbell wrote: > > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote: > > > Split up tools/helpers/xen-init-dom0.c in order to prepare reusing > > > generation of the json configuration by init-xenstore-domain.c. > > > > > > Signed-off-by: Juergen Gross > > > > Wei, was there a reason for using atexit() to free the handles which > > I'm > > not seeing? IOW I think there is a single exit path which could have > > done > > all that today, so Juergen is OK to change it in this way. > > > > No, there isn't particular reason to use atexit. I copied it from xl. > It's OK for Juergen to change it. In which case: Acked-by: Ian Campbell The mixture of logging via xtl and via (f)printf in this code is a bit odd, but that's unchanged by this patch. Someone who was feeling particularly enthusiastic might like to make it use xtl throughout and provide a way to increase the log level. Ian.