From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: JBeulich@suse.com, andrew.cooper3@citrix.com,
ian.campbell@citrix.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
dgdegra@tycho.nsa.gov, konrad@kernel.org, mpohlack@amazon.de
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor.
Date: Thu, 7 Jan 2016 21:25:20 -0500 [thread overview]
Message-ID: <1452219920-14043-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1452219920-14043-1-git-send-email-konrad.wilk@oracle.com>
If the hypervisor is built with we will display it.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
v2: Include HAVE_*, use libxl_zalloc, s/rc/ret/
---
tools/libxl/libxl.c | 24 ++++++++++++++++++++++++
tools/libxl/libxl.h | 5 +++++
tools/libxl/libxl_types.idl | 1 +
tools/libxl/xl_cmdimpl.c | 1 +
4 files changed, 31 insertions(+)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 9207621..b894c1f 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5263,6 +5263,7 @@ libxl_numainfo *libxl_get_numainfo(libxl_ctx *ctx, int *nr)
const libxl_version_info* libxl_get_version_info(libxl_ctx *ctx)
{
+ GC_INIT(ctx);
union {
xen_extraversion_t xen_extra;
xen_compile_info_t xen_cc;
@@ -5270,8 +5271,10 @@ const libxl_version_info* libxl_get_version_info(libxl_ctx *ctx)
xen_capabilities_info_t xen_caps;
xen_platform_parameters_t p_parms;
xen_commandline_t xen_commandline;
+ xen_build_id_t build_id;
} u;
long xen_version;
+ int ret;
libxl_version_info *info = &ctx->version_info;
if (info->xen_version_extra != NULL)
@@ -5304,6 +5307,27 @@ const libxl_version_info* libxl_get_version_info(libxl_ctx *ctx)
xc_version(ctx->xch, XENVER_commandline, &u.xen_commandline);
info->commandline = strdup(u.xen_commandline);
+ u.build_id.len = sizeof(u) - sizeof(u.build_id);
+ ret = xc_version(ctx->xch, XENVER_build_id, &u.build_id);
+ switch ( ret ) {
+ case -EPERM:
+ case -ENODATA:
+ case 0:
+ info->build_id = strdup("");
+ break;
+ default:
+ if (ret > 0) {
+ unsigned int i;
+
+ info->build_id = libxl__zalloc(NOGC, (ret * 2) + 1);
+
+ for (i = 0; i < ret ; i++)
+ snprintf(&info->build_id[i * 2], 3, "%02hhx", u.build_id.buf[i]);
+ } else
+ LOGEV(ERROR, ret, "getting build_id");
+ break;
+ }
+ GC_FREE;
return info;
}
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 05606a7..b91d906 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -218,6 +218,11 @@
#define LIBXL_HAVE_SOFT_RESET 1
/*
+ * LIBXL_HAVE_BUILD_ID means that libxl_version_info has the extra
+ * field for the hypervisor build_id.
+ */
+#define LIBXL_HAVE_BUILD_ID 1
+/*
* libxl ABI compatibility
*
* The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
index 9658356..6c29885 100644
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -355,6 +355,7 @@ libxl_version_info = Struct("version_info", [
("virt_start", uint64),
("pagesize", integer),
("commandline", string),
+ ("build_id", string),
], dir=DIR_OUT)
libxl_domain_create_info = Struct("domain_create_info",[
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index f9933cb..1fbe7f3 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5549,6 +5549,7 @@ static void output_xeninfo(void)
printf("cc_compile_by : %s\n", info->compile_by);
printf("cc_compile_domain : %s\n", info->compile_domain);
printf("cc_compile_date : %s\n", info->compile_date);
+ printf("build_id : %s\n", info->build_id);
return;
}
--
2.1.0
next prev parent reply other threads:[~2016-01-08 2:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:25 [PATCH v3] Add build-id to XENVER hypercall Konrad Rzeszutek Wilk
2016-01-08 2:25 ` [PATCH v3 1/3] xsm/xen_version: Add XSM for the xen_version hypercall (v6) Konrad Rzeszutek Wilk
2016-01-08 17:57 ` Daniel De Graaf
2016-01-12 16:08 ` Jan Beulich
2016-01-08 2:25 ` [PATCH v3 2/3] XENVER_build_id: Provide ld-embedded build-ids (v8) Konrad Rzeszutek Wilk
2016-01-12 16:25 ` Jan Beulich
2016-01-12 16:43 ` Konrad Rzeszutek Wilk
2016-01-12 17:00 ` Jan Beulich
2016-01-14 2:02 ` Konrad Rzeszutek Wilk
2016-01-14 8:58 ` Jan Beulich
2016-01-14 9:07 ` Martin Pohlack
2016-01-14 9:14 ` Jan Beulich
2016-01-25 15:16 ` Konrad Rzeszutek Wilk
2016-01-25 16:10 ` Jan Beulich
2016-01-15 21:49 ` Konrad Rzeszutek Wilk
2016-01-18 8:51 ` Jan Beulich
2016-01-19 16:05 ` Konrad Rzeszutek Wilk
2016-01-19 16:36 ` Jan Beulich
2016-01-19 16:47 ` Konrad Rzeszutek Wilk
2016-02-17 11:37 ` Ian Jackson
2016-01-08 2:25 ` Konrad Rzeszutek Wilk [this message]
2016-01-11 14:12 ` [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor Wei Liu
2016-01-14 2:58 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452219920-14043-4-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad@kernel.org \
--cc=mpohlack@amazon.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).