From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: igvt-g@ml01.01.org, xen-devel@lists.xensource.com,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xudong.hao@intel.com, qemu-devel@nongnu.org,
Jan Beulich <JBeulich@novell.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
vfio-users@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init
Date: Fri, 08 Jan 2016 13:32:56 +0100 [thread overview]
Message-ID: <1452256376.21093.50.camel@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1601081205330.13564@kaball.uk.xensource.com>
Hi,
> > That is true. Given that the only qemu-xen codebase with igd support is
> > 4.7 and 4.7 hasn't been released yet, I am OK with changing the guest
> > visible PCI layout. I might ask for your help in backporting the patches
> > ;-)
What are the 4.7 release plans btw?
> One thing that I forgot to consider is that QEMU 2.5 has been released
> with igd passthrough too and Xen 4.6 + QEMU 2.5 is a combination we
> should support.
>
> However QEMU 2.5 has a serious bug
> (http://marc.info/?l=qemu-devel&m=145172165010604) which probably
> prevents igd passthrough from working at all.
Stumbled over that one too, so my series has a (different) fix for it as
well.
> I asked Xudong to investigate. I am thinking that if the feature
> works in 2.5, we need to support it, therefore we cannot break
> migration by changing the PCI layout.
I'd expect it is broken (at least for older guests). In case 2.5 works
fine as-is we should be able to ditch
TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE altogether b/c it is a no-op in
2.5 because of the bug.
But lets wait for the test results ...
> Otherwise if the feature doesn't work, we could take the liberty to
> make the change. Do you agree?
Yes.
cheers,
Gerd
next prev parent reply other threads:[~2016-01-08 12:32 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 11:41 [PATCH v3 00/11] igd passthrough chipset tweaks Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 06/11] igd: use defines for standard pci config space offsets Gerd Hoffmann
2016-01-06 14:43 ` Stefano Stabellini
[not found] ` <1451994098-6972-1-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-05 11:41 ` [PATCH v3 01/11] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 02/11] pc: remove has_igd_gfx_passthru global Gerd Hoffmann
2016-01-06 14:32 ` [Xen-devel] " Stefano Stabellini
2016-01-19 15:09 ` Eduardo Habkost
2016-01-05 11:41 ` [PATCH v3 03/11] pc: move igd support code to igd.c Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize Gerd Hoffmann
2016-01-06 14:32 ` Stefano Stabellini
2016-01-23 14:51 ` Eduardo Habkost
2016-01-25 8:59 ` Gerd Hoffmann
2016-01-25 11:53 ` Stefano Stabellini
2016-01-05 11:41 ` [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize Gerd Hoffmann
[not found] ` <1451994098-6972-6-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-06 14:41 ` Stefano Stabellini
2016-01-06 15:45 ` Gerd Hoffmann
[not found] ` <1452095101.6096.55.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-19 15:13 ` Eduardo Habkost
[not found] ` <20160119151302.GB3869-CWx9maZTQ9aWdW/7B+e53bcJ0lE8rU3a@public.gmane.org>
2016-01-20 9:10 ` Gerd Hoffmann
2016-01-23 14:52 ` Eduardo Habkost
2016-01-05 11:41 ` [PATCH v3 07/11] igd: revamp host config read Gerd Hoffmann
2016-01-06 15:02 ` Stefano Stabellini
2016-01-06 15:51 ` Gerd Hoffmann
[not found] ` <1452095486.6096.61.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-06 16:23 ` [Xen-devel] " Stefano Stabellini
2016-01-05 11:41 ` [PATCH v3 08/11] igd: add q35 support Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 09/11] igd: move igd-passthrough-isa-bridge to igd.c too Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 10/11] igd: handle igd-passthrough-isa-bridge setup in realize() Gerd Hoffmann
2016-01-06 15:29 ` Stefano Stabellini
2016-01-06 15:52 ` Gerd Hoffmann
2016-01-05 11:41 ` [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init Gerd Hoffmann
2016-01-06 15:36 ` Stefano Stabellini
2016-01-07 7:38 ` Gerd Hoffmann
2016-01-07 13:10 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1601071200210.13564-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2016-01-07 15:50 ` [Qemu-devel] " Gerd Hoffmann
2016-01-08 11:20 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1601071743020.13564-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2016-01-08 12:12 ` [Qemu-devel] " Stefano Stabellini
2016-01-08 12:32 ` Gerd Hoffmann [this message]
2016-01-08 12:38 ` Stefano Stabellini
2016-01-05 13:07 ` [PATCH v3 00/11] igd passthrough chipset tweaks Michael S. Tsirkin
2016-01-28 19:35 ` [vfio-users] " Alex Williamson
2016-01-29 2:22 ` [iGVT-g] " Kay, Allen M
2016-01-29 2:54 ` Alex Williamson
2016-01-29 6:21 ` Jike Song
2016-01-29 21:58 ` Kay, Allen M
2016-02-02 7:07 ` Tian, Kevin
[not found] ` <AADFC41AFE54684AB9EE6CBC0274A5D15F794020-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-02-02 19:10 ` [iGVT-g] " Kay, Allen M
2016-02-02 19:37 ` [iGVT-g] [vfio-users] " Alex Williamson
2016-02-02 23:32 ` Kay, Allen M
2016-01-29 7:09 ` Gerd Hoffmann
2016-01-29 17:59 ` Alex Williamson
2016-01-30 1:18 ` [iGVT-g] " Kay, Allen M
2016-01-31 17:42 ` Alex Williamson
2016-02-02 0:04 ` Kay, Allen M
2016-02-02 6:42 ` [Xen-devel] " Tian, Kevin
2016-02-02 11:50 ` David Woodhouse
2016-02-02 14:54 ` Alex Williamson
2016-02-02 15:06 ` David Woodhouse
2016-02-02 14:38 ` Alex Williamson
2016-02-01 12:49 ` Gerd Hoffmann
[not found] ` <1454330962.10168.34.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-01 22:16 ` Alex Williamson
2016-02-02 7:43 ` [vfio-users] " Gerd Hoffmann
2016-02-02 7:01 ` [iGVT-g] " Tian, Kevin
2016-02-02 8:56 ` [iGVT-g] [vfio-users] " Gerd Hoffmann
2016-02-02 16:31 ` Kevin O'Connor
2016-02-02 16:49 ` Laszlo Ersek
2016-02-02 20:18 ` Alex Williamson
2016-02-03 6:08 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452256376.21093.50.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=JBeulich@novell.com \
--cc=andrew.cooper3@citrix.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=igvt-g@ml01.01.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vfio-users@redhat.com \
--cc=xen-devel@lists.xensource.com \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).