Re: [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2016-01-08 at 14:12 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm
> xs control path"):
> > So, do I understand correctly that the states (combinations of bits)
> > are:
> 
> No.
> 
> > Describing SPLIT as an "ID" is a bit odd (it's a kind of meta thing)
> > but I
> > suppose I can see why it is done this way. An alternative might be to
> > have
> > a separate bit for the PV|DM case together, maybe you discarded that
> > possibility though?
> 
> Perhaps things will be clearer with this comment, which I've just
> added to add in this patch:

Much thanks. One nit:
> 
>   * In xenstore we record which qemus a domain has.  This is necessary
>   * for correct teardown.  And, we also record whether the xenstore
>   * paths are unified, as discussed above, so that subsequent libxl
>   * operations can do the right thing.  This is what the EMUID_SPLIT
>   * flag is for.

EMUID_SPLIT actually records the inverse (i.e. that they are split, rather
than unified as the previous text is discussing).

I knew what you meant though, and clarifying it could well make it less
obvious I suspect.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel