From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2] tools/libxc: Adjust error handling in map_p2m_list() to fix CentOS 7 build
Date: Fri, 8 Jan 2016 15:32:32 +0000 [thread overview]
Message-ID: <1452267152.26438.10.camel@citrix.com> (raw)
In-Reply-To: <568FCB1F.6000207@suse.com>
On Fri, 2016-01-08 at 15:43 +0100, Juergen Gross wrote:
> On 08/01/16 15:38, Andrew Cooper wrote:
> > The "goto err;" for malloc() error handling would cause the cleanup
> > code
> > to use 'ptes' before it had been initialised, and causing a build
> > failure because of -Werror=maybe-uninitialised.
> >
> > Use "goto err;" consistently for all error handling.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Acked, applied, thanks.
prev parent reply other threads:[~2016-01-08 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:38 [PATCH v2] tools/libxc: Adjust error handling in map_p2m_list() to fix CentOS 7 build Andrew Cooper
2016-01-08 14:43 ` Juergen Gross
2016-01-08 15:32 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452267152.26438.10.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).