From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] tools/libxc: Adjust error handling in map_p2m_list() to fix CentOS 7 build Date: Fri, 8 Jan 2016 15:32:32 +0000 Message-ID: <1452267152.26438.10.camel@citrix.com> References: <1452263883-22144-1-git-send-email-andrew.cooper3@citrix.com> <568FCB1F.6000207@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <568FCB1F.6000207@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org On Fri, 2016-01-08 at 15:43 +0100, Juergen Gross wrote: > On 08/01/16 15:38, Andrew Cooper wrote: > > The "goto err;" for malloc() error handling would cause the cleanup > > code > > to use 'ptes' before it had been initialised, and causing a build > > failure because of -Werror=maybe-uninitialised. > > > > Use "goto err;" consistently for all error handling. > > > > Signed-off-by: Andrew Cooper > > Reviewed-by: Juergen Gross Acked, applied, thanks.