From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Doug Goldstein <cardoe@cardoe.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
xen-devel@lists.xen.org,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] build: convert NR_CPUS to Kconfig
Date: Mon, 11 Jan 2016 16:49:49 +0100 [thread overview]
Message-ID: <1452527389.11427.3.camel@citrix.com> (raw)
In-Reply-To: <5693D8BB02000078000C57FE@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1053 bytes --]
On Mon, 2016-01-11 at 08:30 -0700, Jan Beulich wrote:
> > > > On 11.01.16 at 16:06, <cardoe@cardoe.com> wrote:
> > On 1/11/16 8:24 AM, Jan Beulich wrote:
> > > Considering the size of the patch, the doubling of the
> > > identifier's
> > > length, and the fact that even Linux continues to use NR_CPUS
> > > I wonder whether we wouldn't be better of simply having
> > >
> > > #define NR_CPUS CONFIG_NR_CPUS
> >
> > Is that a "please do this for a v2" or "what do the other
> > maintainers
> > think?" statement?
>
> More the former, unless the latter gets answered by "no, this is a
> bad idea".
>
FWIW, I like Jan's idea and, although not too big of a deal, I'd be
happy to still have the shorter identifier (NR_CPUS) available in
sched_credit2.c
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-11 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 23:17 [PATCH 1/2] build: introduce CONFIG_NR_CPUS in Kconfig Doug Goldstein
2016-01-08 23:17 ` [PATCH 2/2] build: convert NR_CPUS to Kconfig Doug Goldstein
2016-01-09 14:36 ` Andrew Cooper
2016-01-11 14:24 ` Jan Beulich
2016-01-11 15:06 ` Doug Goldstein
2016-01-11 15:30 ` Jan Beulich
2016-01-11 15:49 ` Dario Faggioli [this message]
2016-01-09 13:43 ` [PATCH 1/2] build: introduce CONFIG_NR_CPUS in Kconfig Andrew Cooper
2016-01-11 14:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452527389.11427.3.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).