From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: [PATCH] tools: fix python install with "xentoollog" Date: Tue, 12 Jan 2016 22:16:11 -0500 Message-ID: <1452654971-4522-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aJBv7-0000bI-19 for xen-devel@lists.xenproject.org; Wed, 13 Jan 2016 03:16:25 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Wei Liu , Boris Ostrovsky , Ian Jackson , Ian Campbell , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org commit 5d3dc8671521ea4a4f753e77d3e7fb3a3a6f5f80 "tools: Refactor "xentoollog" into its own library" with older python versions (2.6.4) will fail to the build if attempted to be done twice (which happens due to pygrub dependencies). make -C python DESTDIR=/tmp make -C python DESTDIR=/tmp The second one will fail with: error: -Wl, -rpath-link=../../tools/libs/toollog: No such file or directory even thought the directory is there (with the libs). Andrew pointed out that the linker additions should be in the "extra_link_args" rather than "depends". And true enough - with that modification it builds. CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Boris Ostrovsky Suggested-by: Andrew Cooper Signed-off-by: Konrad Rzeszutek Wilk --- tools/python/setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/python/setup.py b/tools/python/setup.py index 9771cc4..604b314 100644 --- a/tools/python/setup.py +++ b/tools/python/setup.py @@ -17,7 +17,8 @@ xc = Extension("xc", include_dirs = [ PATH_XEN, PATH_LIBXENTOOLLOG + "/include", PATH_LIBXC + "/include", "xen/lowlevel/xc" ], library_dirs = [ PATH_LIBXC ], libraries = [ "xenctrl", "xenguest" ], - depends = [ PATH_LIBXC + "/libxenctrl.so", PATH_LIBXC + "/libxenguest.so", "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ], + depends = [ PATH_LIBXC + "/libxenctrl.so", PATH_LIBXC + "/libxenguest.so" ], + extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ], sources = [ "xen/lowlevel/xc/xc.c" ]) xs = Extension("xs", -- 2.5.0