From: Ian Campbell <ian.campbell@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [OSSTEST PATCH] enable FLASK_ENABLE when using it for testing
Date: Thu, 14 Jan 2016 16:22:56 +0000 [thread overview]
Message-ID: <1452788576.32341.8.camel@citrix.com> (raw)
In-Reply-To: <1452783526-29173-1-git-send-email-cardoe@cardoe.com>
On Thu, 2016-01-14 at 08:58 -0600, Doug Goldstein wrote:
> Currently OSSTest has 'XSM' tests but XSM and FLASK are two different
> options and OSSTests's 'XSM' test depends on FLASK so ensure that FLASK
> is enabled so that tests pass.
IMHO the xen/Kconfig should be arranged such that if XSM is enabled then
FLASK is on by default. Having XSM but not Flask as what happens if you
enable XSM isn't helpful.
However, xen/common/Kconfig already has "default y" and "depends XSM" for
the FLASK entry, which I would have said was what was required to behave as
I suggest.
So why isn't it I wonder?
After a plain "make -C xen defconfig" I end up with a xen/.config
containing "CONFIG_XSM is not set" and no mention of CONFIG_FLASK (as
expected, due to the depends).
Adding CONFIG_XSM=y to the end of xen/.config and running "make -C xen
oldconfig" I then get asked:
FLux Advanced Security Kernel support (FLASK) [Y/n/?] (NEW)
IOW it does appear to be defaulting to on (I also get asked about
LATE_HWDOM).
osstest uses "olddefconfig", and with:
$ make -C xen olddefconfig
$ echo 'CONFIG_XSM=y' >> xen/.config
$ make -C xen olddefconfig
I end up with both XSM and FLASK enabled:
$ grep -E XSM\|FLASK xen/.config
CONFIG_FLASK=y
CONFIG_XSM=y
which is what we want and is expected etc. Looking at the results of the
latest xen-unstable http://logs.test-lab.xenproject.org/osstest/logs/77945/
and specifically at
http://logs.test-lab.xenproject.org/osstest/logs/77945/build-amd64-xsm/build/xen-hv-config
it seems that the automated version is doing what is expected too. IOW this
patch is both unnecessary (since it already works) and wrong (since it is
working how we want it to) and the issue exhibited by the test cases in
77945 is something different.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-14 16:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 14:58 [OSSTEST PATCH] enable FLASK_ENABLE when using it for testing Doug Goldstein
2016-01-14 14:28 ` [OSSTEST PATCH] pass --{enable, disable}-xsmpolicy based on XSM state Doug Goldstein
2016-01-13 19:30 ` [xen-unstable test] 77945: regressions - FAIL osstest service owner
2016-01-14 9:30 ` Jan Beulich
2016-01-14 11:42 ` Ian Campbell
2016-01-14 12:50 ` Jan Beulich
2016-01-14 13:57 ` Ian Campbell
2016-01-14 14:07 ` Doug Goldstein
2016-01-14 14:44 ` Ian Campbell
2016-01-14 14:54 ` Doug Goldstein
2016-01-14 14:48 ` Jan Beulich
2016-01-14 15:04 ` Doug Goldstein
2016-01-14 16:27 ` [xen-unstable test] 77945: regressions - FAIL [and 2 more messages] Ian Jackson
2016-01-14 17:07 ` Doug Goldstein
2016-01-14 17:18 ` Ian Jackson
2016-01-14 17:25 ` Ian Campbell
2016-01-14 19:10 ` Doug Goldstein
2016-01-15 16:06 ` Jan Beulich
2016-01-15 17:06 ` Ian Campbell
2016-01-15 17:10 ` Ian Jackson
2016-01-15 17:15 ` Jan Beulich
2016-01-15 17:24 ` Andrew Cooper
2016-01-15 17:42 ` Ian Campbell
2016-01-18 7:49 ` Jan Beulich
2016-01-18 8:55 ` Andrew Cooper
2016-01-18 9:41 ` Ian Campbell
2016-01-18 9:47 ` Jan Beulich
2016-01-18 11:22 ` Ian Campbell
2016-01-18 11:28 ` Ian Jackson
2016-01-18 11:36 ` Ian Campbell
2016-01-18 12:09 ` Ian Campbell
2016-01-15 17:21 ` Doug Goldstein
2016-01-14 21:40 ` [OSSTEST PATCH] pass --{enable, disable}-xsmpolicy based on XSM state Doug Goldstein
2016-01-16 20:50 ` Doug Goldstein
2016-01-14 16:22 ` Ian Campbell [this message]
2016-01-14 16:34 ` [OSSTEST PATCH] enable FLASK_ENABLE when using it for testing Doug Goldstein
2016-01-16 20:54 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452788576.32341.8.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).