xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xensource.com,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] QEMU as non-root and PCI passthrough do not mix
Date: Thu, 14 Jan 2016 17:40:00 +0000	[thread overview]
Message-ID: <1452793200.32341.28.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1601141620260.16178@kaball.uk.xensource.com>

On Thu, 2016-01-14 at 17:32 +0000, Stefano Stabellini wrote:
> 
> > > +    LOG(DEBUG, "QEMU needs to be run as root for PCI passthrough to
> > > work");
> > 
> > Shouldn't there be an if here, and/or an error return?
> 
> Unfortunately we cannot get the user used to run QEMU with from here.
> However, even without this change, there is already plenty of
> information printed out:
> 
> - xl prints:
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
> error message from QMP server: Device initialization failed
> 
> - qemu prints:
> [00:03.0] xen_pt_initfn: Error: Failed to "open" the real pci device. rc:
> -13

All that is under normal (i.e. successful) usage? The presence of such spew
under those circumstances should probably be considered a bug. Certainly
adding more noise doesn't seem desirable.

libxl should be able to get the user, either from the json stash of the
config or by writing it somewhere on create so it can get it back when it
needs it.

That reminds me -- how does the qemu user selection work over migrate? Does
it remember the specific user or does it try and pick it again on the other
end? Do we require all hosts in a pool to have been setup in the same way
i.e. either xen-qemuuser-domid$i or xen-qemuuser-shared but not a mixture?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-01-14 17:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 16:52 [PATCH] QEMU as non-root and PCI passthrough do not mix Stefano Stabellini
2016-01-14 10:39 ` Ian Campbell
2016-01-14 17:32   ` Stefano Stabellini
2016-01-14 17:34     ` Ian Jackson
2016-01-15 14:14       ` Stefano Stabellini
2016-01-15 14:29         ` Konrad Rzeszutek Wilk
2016-01-15 14:49           ` Stefano Stabellini
2016-01-15 14:56             ` Ian Campbell
2016-01-14 17:40     ` Ian Campbell [this message]
2016-01-14 17:42       ` Ian Jackson
2016-01-15  9:53         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452793200.32341.28.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).