From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 3/3] xenstat: handle more than 1024
	domains
Date: Fri, 15 Jan 2016 15:35:12 +0000
Message-ID: <1452872112.6020.40.camel@citrix.com>
References: <1451919353-11547-1-git-send-email-jgross@suse.com>
	<1451919353-11547-4-git-send-email-jgross@suse.com>
	<20160104163806.GG12639@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160104163806.GG12639@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Juergen Gross <jgross@suse.com>
Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2016-01-04 at 16:38 +0000, Wei Liu wrote:
> On Mon, Jan 04, 2016 at 03:55:53PM +0100, Juergen Gross wrote:

> > -	dominfo = get_domain_ids(node->handle->xc_handle, &num_doms);
> > -	if (dominfo == NULL)
> > -		return;
> > +	for (;;) {
> > +		num_doms = xc_domain_getinfolist(node->handle-
> > >xc_handle, next_domid, 1024, dominfo);
> 
> Some lines have exceeded 80 columns. Not really your fault so no need to
> resend.

If not the person adding the lines as apparently fresh code then whose
fault is it?

These ones seem pretty trivial to wrap correctly so I think I would prefer
to see them done.

I'll apply #1 and #2 in a moment and expect a resend of this one. Sorry for
the delay both in applying and commenting, looks like these got buried in
the post vacation pile.

Ian.