xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST v2 07/12] ts-debian-di-install: Allow Di Version to come from runvars
Date: Mon, 18 Jan 2016 14:28:52 +0000	[thread overview]
Message-ID: <1453127337-16136-7-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1453127319.6020.156.camel@citrix.com>

and following the lead of the suite arrange for a version selected
from the defaults to be written back to the runvars.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: s/diversion/di_version/
---
 Osstest/Debian.pm    | 15 ++++++++++++++-
 ts-debian-di-install |  3 ++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 93b0ad4..daca0b7 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -35,7 +35,7 @@ BEGIN {
     @ISA         = qw(Exporter);
     @EXPORT      = qw(debian_boot_setup
                       debian_overlays
-                      debian_guest_suite
+                      debian_guest_suite debian_guest_di_version
                       %preseed_cmds
                       preseed_base
                       preseed_create
@@ -1352,4 +1352,17 @@ sub debian_guest_suite ($) {
     return $gho->{Suite};
 }
 
+sub debian_guest_di_version ($) {
+    my ($gho) = @_;
+
+    $gho->{DiVersion} //= guest_var($gho,'di_version',undef);
+
+    if (!$gho->{DiVersion}) {
+	$gho->{DiVersion} = $c{TftpDiVersion};
+	store_runvar("$gho->{Guest}_di_version", $gho->{DiVersion});
+    }
+
+    return $gho->{DiVersion};
+}
+
 1;
diff --git a/ts-debian-di-install b/ts-debian-di-install
index 9a513d3..9875bef 100755
--- a/ts-debian-di-install
+++ b/ts-debian-di-install
@@ -151,7 +151,8 @@ sub setup_netboot($$$)
 	die if $r{ "$gho->{Guest}_netboot_kernel" }
 	||     $r{ "$gho->{Guest}_netboot_ramdisk" };
 
-	my $di_path = $c{TftpPath}.'/'.$ho->{Tftp}{DiBase}.'/'.${arch}.'/'.$c{TftpDiVersion}.'-'.$ho->{Suite};
+	my $di_path = $c{TftpPath}.'/'.$ho->{Tftp}{DiBase}.'/'.${arch}.'/'.\
+	    debian_guest_diversion($ho).'-'.$ho->{Suite};
 
         if (${arch} =~ m/amd64|i386/) {
 	    $kernel = "$di_path/vmlinuz-xen";
-- 
2.6.1

  parent reply	other threads:[~2016-01-18 14:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 14:28 [PATCH OSSTEST v2 00/12] Specify host and guest os version in runvars Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 02/12] target_var: Support fallback to all_(guest|host)_$vn Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 04/12] mfi-common: always add host suite to hostos_runvars Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 05/12] mfi-common: Always add debian_suite to debian_runvars Ian Campbell
2016-01-19 13:36   ` Ian Jackson
2016-01-18 14:28 ` [PATCH OSSTEST v2 06/12] ts-host-install: Support DiVersion coming from runvars Ian Campbell
2016-01-18 14:28 ` Ian Campbell [this message]
2016-01-19 13:37   ` [PATCH OSSTEST v2 07/12] ts-debian-di-install: Allow Di Version to come " Ian Jackson
2016-01-18 14:28 ` [PATCH OSSTEST v2 08/12] make-flight: Set di_version runvar on d-i based test jobs Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 09/12] mfi-common: Set di_version for build & test host install Ian Campbell
2016-01-19 13:38   ` Ian Jackson
2016-01-18 14:28 ` [PATCH OSSTEST v2 10/12] Qualify TftpDiVersion with the suite Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 11/12] mfi-common: usual_debianhvm_image: derive version from $guestsuite Ian Campbell
2016-01-18 14:28 ` [PATCH OSSTEST v2 12/12] make-flight: Use older Debian for host and guest OS with older Xen Ian Campbell
2016-01-19 13:39   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453127337-16136-7-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).