From: Ian Campbell <ian.campbell@citrix.com>
To: Wen Congyang <wency@cn.fujitsu.com>,
xen devel <xen-devel@lists.xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Wei Liu <wei.liu2@citrix.com>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v4 3/5] tools/libxc: don't send end record if remus fails
Date: Mon, 18 Jan 2016 16:53:10 +0000 [thread overview]
Message-ID: <1453135990.6020.194.camel@citrix.com> (raw)
In-Reply-To: <1453095622-14859-4-git-send-email-wency@cn.fujitsu.com>
On Mon, 2016-01-18 at 13:40 +0800, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
What was the outcoming of Andy's comment on v1 regarding error handling for
->postcopy?
> ---
> tools/libxc/xc_sr_save.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> index 88d85ef..e532168 100644
> --- a/tools/libxc/xc_sr_save.c
> +++ b/tools/libxc/xc_sr_save.c
> @@ -795,7 +795,7 @@ static int save(struct xc_sr_context *ctx, uint16_t
> guest_type)
>
> rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks-
> >data);
> if ( rc <= 0 )
> - ctx->save.checkpointed = false;
> + goto err;
> }
> } while ( ctx->save.checkpointed );
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-18 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 5:40 [PATCH v4 0/5] migration/remus: bug fix and cleanup Wen Congyang
2016-01-18 5:40 ` [PATCH v4 1/5] remus: don't call stream_continue() when doing failover Wen Congyang
2016-01-18 16:45 ` Ian Campbell
2016-01-19 1:05 ` Wen Congyang
2016-01-18 5:40 ` [PATCH v4 2/5] remus: resume immediately if libxl__xc_domain_save_done() completes Wen Congyang
2016-01-18 16:51 ` Ian Campbell
2016-01-19 1:01 ` Wen Congyang
2016-01-19 11:01 ` Ian Campbell
2016-01-18 5:40 ` [PATCH v4 3/5] tools/libxc: don't send end record if remus fails Wen Congyang
2016-01-18 16:53 ` Ian Campbell [this message]
2016-01-18 16:53 ` Ian Campbell
2016-01-18 5:40 ` [PATCH v4 4/5] tools/libxc: error handling for the postcopy() callback Wen Congyang
2016-01-18 16:53 ` Ian Campbell
2016-01-18 5:40 ` [PATCH v4 5/5] tools/libxl: remove unused function libxl__domain_save_device_model() Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453135990.6020.194.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=hongyang.yang@easystack.cn \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).