From: Wen Congyang <wency@cn.fujitsu.com>
To: xen devel <xen-devel@lists.xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: [PATCH v5 1/6] remus: don't do failover if we don't have an consistent state
Date: Tue, 19 Jan 2016 15:17:37 +0800 [thread overview]
Message-ID: <1453187862-24331-2-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1453187862-24331-1-git-send-email-wency@cn.fujitsu.com>
We will have an consistent state when a CHECKPOINT_END record
is received. After the first CHECKPOINT_END record is received,
we will buffer all records until the next CHECKPOINT_END record
is received. So if the checkpoint() callback returns XGR_CHECKPOINT_FAILOVER,
we only can do failover if ctx->restore.buffer_all_records is
true.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
tools/libxc/xc_sr_restore.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/libxc/xc_sr_restore.c b/tools/libxc/xc_sr_restore.c
index 05159bb..9fe2829 100644
--- a/tools/libxc/xc_sr_restore.c
+++ b/tools/libxc/xc_sr_restore.c
@@ -493,7 +493,11 @@ static int handle_checkpoint(struct xc_sr_context *ctx)
break;
case XGR_CHECKPOINT_FAILOVER:
- rc = BROKEN_CHANNEL;
+ if ( ctx->restore.buffer_all_records )
+ rc = BROKEN_CHANNEL;
+ else
+ /* We don't have an consistent state */
+ rc = -1;
goto err;
default: /* Other fatal error */
--
2.5.0
next prev parent reply other threads:[~2016-01-19 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 7:17 [PATCH v5 0/6] migration/remus: bug fix and cleanup Wen Congyang
2016-01-19 7:17 ` Wen Congyang [this message]
2016-01-19 10:48 ` [PATCH v5 1/6] remus: don't do failover if we don't have an consistent state Ian Campbell
2016-01-19 15:35 ` Andrew Cooper
2016-01-20 0:42 ` Wen Congyang
2016-01-19 7:17 ` [PATCH v5 2/6] remus: don't call stream_continue() when doing failover Wen Congyang
2016-01-19 10:50 ` Ian Campbell
2016-01-19 7:17 ` [PATCH v5 3/6] remus: resume immediately if libxl__xc_domain_save_done() completes Wen Congyang
2016-01-19 10:55 ` Ian Campbell
2016-01-20 0:41 ` Wen Congyang
2016-01-19 7:17 ` [PATCH v5 4/6] tools/libxc: don't send end record if remus fails Wen Congyang
2016-01-19 7:17 ` [PATCH v5 5/6] tools/libxc: error handling for the postcopy() callback Wen Congyang
2016-01-19 7:17 ` [PATCH v5 6/6] tools/libxl: remove unused function libxl__domain_save_device_model() Wen Congyang
2016-01-20 17:40 ` [PATCH v5 0/6] migration/remus: bug fix and cleanup Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453187862-24331-2-git-send-email-wency@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=hongyang.yang@easystack.cn \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).