From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm Date: Tue, 19 Jan 2016 15:28:35 +0100 Message-ID: <1453213715.11427.136.camel@citrix.com> References: <1451925649.13361.193.camel@citrix.com> <1453183100-50700-1-git-send-email-czylin@uwaterloo.ca> <22174.17133.666899.340909@mariner.uk.xensource.com> <1453213287.29930.52.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2755238615986427784==" Return-path: In-Reply-To: <1453213287.29930.52.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Ian Jackson , Chester Lin Cc: george.dunlap@eu.citrix.com, jtotto@uwaterloo.ca, stefano.stabellini@eu.citrix.com, hjarmstr@uwaterloo.ca, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============2755238615986427784== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-zvnhwWzcxF9WZef7zh6K" --=-zvnhwWzcxF9WZef7zh6K Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-01-19 at 14:21 +0000, Ian Campbell wrote: > On Tue, 2016-01-19 at 14:06 +0000, Ian Jackson wrote: > > I am not a fan of the cast as a solution.=C2=A0=C2=A0I would rather, pr= efer > > to > > regularise the situation.=C2=A0=C2=A0If my co-maintainers agree about t= he > > desirability of expecting libxl callers to use enum values from Xen > > public headers, >=20 > libxl_shutdown_reason has the same issues, libxl_tsc_mode also might, > as > might libxl_timer_mode. I'm not sure if there are others.=20 > (FTR) libxl_scheduler too, probably? > I think we > generally handle all these the way psr is handled today (with casts > and/or > explicit conversion switches). >=20 and in fact, libxl_scheduler --touched in another patch of this series-- is also handled in a similar way, and in that case, you seemed to be fine with it? (and I'm not complaining, I'm just genuinely confused :-) ) Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-zvnhwWzcxF9WZef7zh6K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlaeSBMACgkQk4XaBE3IOsSSDACgnszM5oUZiYHcK/7ovtoiu8eW 0aIAn1YTo7D7VphT5wE70dZbYSjR3jB5 =gC8f -----END PGP SIGNATURE----- --=-zvnhwWzcxF9WZef7zh6K-- --===============2755238615986427784== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2755238615986427784==--