From: Ian Campbell <ian.campbell@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 4/4] x86/PV: enable the emulated PIT
Date: Wed, 20 Jan 2016 11:57:05 +0000 [thread overview]
Message-ID: <1453291025.26343.77.camel@citrix.com> (raw)
In-Reply-To: <569D27AB.3090304@citrix.com>
On Mon, 2016-01-18 at 18:58 +0100, Roger Pau Monné wrote:
> You certainly are more familiar with the migration code than me, but
> wouldn't it be enough to add a new field to libxl_domain_build_info
> (uint32_t emulation_flags), and teach
> libxl_domain_build_info_gen_json/libxl__domain_build_info_parse_json
> how to properly parse it?
Is libxl not already aware whether a domain is to be dmlite vs pv or hvm
based on the domain config?
As such can't it figure out the hardcoded set to use already without
actually needing to expose this in libxl API (until we actually have a
desire to expose such nobs to users)? Can't this work on resume just like
it does on create?
> This however raises the question about how to signal that the field is
> not initialised, because 0 is a valid value (maybe ~0)?
In libxl's API we tend to try and avoid opaque hex numbers, so the natural
result would be a struct full of libxl_defbool options, which IIRC already
get properly propagated and have handling for defaulting already in place.
Ian.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-20 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 14:59 [PATCH v2 0/4] HVMlite: minor fixes and Dom0 preparatory patches Roger Pau Monne
2016-01-15 14:59 ` [PATCH v2 1/4] xen/elfnotes: check phys_entry against UNSET_ADDR32 Roger Pau Monne
2016-01-19 9:21 ` Wei Liu
2016-01-15 14:59 ` [PATCH v2 2/4] libelf: rewrite symtab/strtab loading for Dom0 Roger Pau Monne
2016-01-15 14:59 ` [PATCH v2 3/4] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise Roger Pau Monne
2016-01-15 14:59 ` [PATCH v2 4/4] x86/PV: enable the emulated PIT Roger Pau Monne
2016-01-15 17:08 ` Jan Beulich
2016-01-15 17:45 ` [PATCH v3 " Roger Pau Monne
2016-01-18 7:43 ` Jan Beulich
2016-01-18 9:29 ` Andrew Cooper
2016-01-18 9:44 ` Jan Beulich
2016-01-18 10:41 ` Andrew Cooper
2016-01-18 11:06 ` Jan Beulich
2016-01-18 16:10 ` Andrew Cooper
2016-01-18 16:27 ` Jan Beulich
2016-01-18 16:33 ` Andrew Cooper
2016-01-18 16:44 ` Jan Beulich
2016-01-18 17:58 ` Roger Pau Monné
2016-01-18 18:03 ` Andrew Cooper
2016-01-19 9:24 ` Ian Campbell
2016-01-19 10:09 ` Andrew Cooper
2016-01-19 10:28 ` Ian Campbell
2016-01-19 10:56 ` Andrew Cooper
2016-01-20 11:57 ` Ian Campbell [this message]
2016-01-18 9:50 ` Roger Pau Monné
2016-01-18 10:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453291025.26343.77.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).