xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, David Vrabel <david.vrabel@citrix.com>
Subject: Re: netfront/netback multiqueue exhausting grants
Date: Wed, 20 Jan 2016 14:52:51 +0000	[thread overview]
Message-ID: <1453301571.26343.127.camel@citrix.com> (raw)
In-Reply-To: <569F9C6A.9070008@oracle.com>

On Wed, 2016-01-20 at 09:40 -0500, Boris Ostrovsky wrote:
> On 01/20/2016 07:23 AM, Ian Campbell wrote:
> > There have been a few reports recently[0] which relate to a failure of
> > netfront to allocate sufficient grant refs for all the queues:
> > 
> > [    0.533589] xen_netfront: can't alloc rx grant refs
> > [    0.533612] net eth0: only created 31 queues
> > 
> > Which can be worked around by increasing the number of grants on the
> > hypervisor command line or by limiting the number of queues permitted
> > by
> > either back or front using a module param (which was broken but is now
> > fixed on both sides, but I'm not sure it has been backported everywhere
> > such that it is a reliable thing to always tell users as a workaround).
> > 
> > Is there any plan to do anything about the default/out of the box
> > experience? Either limiting the number of queues or making both ends
> > cope
> > more gracefully with failure to create some queues (or both) might be
> > sufficient?
> > 
> > I think the crash after the above in the first link at [0] is fixed? I
> > think that was the purpose of ca88ea1247df "xen-netfront: update
> > num_queues
> > to real created" which was in 4.3.
> 
> I think ca88ea1247df is the solution --- it will limit the number of 
> queues.

That's in 4.4, which the first link at [0] claimed to have tested. I can
see this fixing the crash, but does it really fix the "actually works with
less queues than it tried to get" issue?

In any case having exhausted the grant entries creating queues there aren't
any left to shuffle actual data around, is there? (or are those
preallocated too?)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-01-20 14:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 12:23 netfront/netback multiqueue exhausting grants Ian Campbell
2016-01-20 14:40 ` Boris Ostrovsky
2016-01-20 14:52   ` Ian Campbell [this message]
2016-01-20 15:02     ` David Vrabel
2016-01-20 15:10       ` Boris Ostrovsky
2016-01-20 15:16         ` Ian Campbell
2016-01-21 10:12           ` Ian Campbell
2016-01-21 10:25             ` Wei Liu
2016-01-21 10:37               ` Ian Campbell
2016-01-21 10:52                 ` Wei Liu
2016-01-20 16:18 ` annie li
2016-01-21 10:56 ` David Vrabel
2016-01-21 12:19   ` Ian Campbell
2016-01-21 14:17     ` David Vrabel
2016-01-21 15:11       ` annie li
2016-01-22  3:36     ` Bob Liu
2016-01-22  7:53       ` Jan Beulich
2016-01-22 10:40         ` Bob Liu
2016-01-22 11:02           ` Jan Beulich
2016-01-23  0:29             ` Bob Liu
2016-01-25  9:53               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453301571.26343.127.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).