From: Ian Campbell <ian.campbell@citrix.com>
To: george.dunlap@citrix.com
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH 2/2] xenalyze: remove cr3_compare_total
Date: Fri, 22 Jan 2016 14:27:29 +0000 [thread overview]
Message-ID: <1453472849-25496-2-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1453472830.4320.97.camel@citrix.com>
gcc-6 complains:
xenalyze.c:4132:9: error: 'cr3_compare_total' defined but not used [-Werror=unused-function]
int cr3_compare_total(const void *_a, const void *_b) {
^~~~~~~~~~~~~~~~~
I believe it is correct.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/xentrace/xenalyze.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 4bcaf83..6520790 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -4129,23 +4129,6 @@ void cr3_dump_list(struct cr3_value_struct *head){
struct cr3_value_struct **qsort_array;
int i, N=0;
- int cr3_compare_total(const void *_a, const void *_b) {
- struct cr3_value_struct *a=*(typeof(&a))_a;
- struct cr3_value_struct *b=*(typeof(&a))_b;
-
- if(a->total_time.cycles < b->total_time.cycles)
- return 1;
- else if(b->total_time.cycles == a->total_time.cycles) {
- if(a->total_time.count < b->total_time.count)
- return 1;
- else if(a->total_time.count == b->total_time.count)
- return 0;
- else
- return -1;
- } else
- return -1;
- }
-
int cr3_compare_start(const void *_a, const void *_b) {
struct cr3_value_struct *a=*(typeof(&a))_a;
struct cr3_value_struct *b=*(typeof(&a))_b;
--
2.6.1
next prev parent reply other threads:[~2016-01-22 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 14:27 [PATCH 0/2] xenalyze: fixes for gcc-6's -Wmisleading-indentation Ian Campbell
2016-01-22 14:27 ` [PATCH 1/2] xenalyze: fix misleading indentation Ian Campbell
2016-01-26 11:57 ` George Dunlap
2016-01-22 14:27 ` Ian Campbell [this message]
2016-01-26 12:01 ` [PATCH 2/2] xenalyze: remove cr3_compare_total George Dunlap
2016-01-26 16:51 ` [PATCH 0/2] xenalyze: fixes for gcc-6's -Wmisleading-indentation Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453472849-25496-2-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).