From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory
Date: Mon, 25 Jan 2016 12:44:06 +0000 [thread overview]
Message-ID: <1453725846.4320.150.camel@citrix.com> (raw)
In-Reply-To: <1453725065.4320.147.camel@citrix.com>
On Mon, 2016-01-25 at 12:31 +0000, Ian Campbell wrote:
> On Mon, 2016-01-25 at 13:01 +0100, Olaf Hering wrote:
> > On Fri, Jan 15, Ian Campbell wrote:
> >
> > > libxenforeignmemory will provide a stable API and ABI for mapping
> > > foreign domain memory (subject to appropriate privileges).
> >
> > I think this will break my Xen pkg build:
> >
> > [ 333s] kdd-xen.c: In function 'kdd_access_physical_page':
> > [ 333s] kdd-xen.c:508:15: warning: implicit declaration of function
> > 'xc_map_foreign_range' [-Wimplicit-function-declaration]
> > [ 333s] map = xc_map_foreign_range(g->xc_handle,
> > [ 333s] ^
> > [ 333s] kdd-xen.c:508:13: warning: assignment makes pointer from
> > integer
> > without a cast [-Wint-conversion]
> > [ 333s] map = xc_map_foreign_range(g->xc_handle,
> > [ 333s] ^
>
> I supposed this wasn't built by default and I missed it, but it looks to be
> built unconditionally. I wonder why I didn't see this.
Turns out this code doesn't use Werror, so it was failing but was lost in
the noise (e.g. you can find it in http://logs.test-lab.xenproject.org/osst
est/logs/78820/build-amd64/5.ts-xen-build.log)
> Defining XC_WANT_COMPAT_MAP_FOREIGN_API while building is one way to fix,
> or else kdd would need to switch to the new interface. The latter is
> obviously better long term, but the former is done for a bunch of stuff in
> tree so it might as well be done here too.
>
> The machine with the trees I used for this work is currently unavailable
> (network issues in our office), but I'll see if I can reproduce.
I did, I'll send a patch taking the easy way out as a reply.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-25 12:44 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1452864168.32341.97.camel@citrix.com>
2016-01-15 13:22 ` [PATCH XEN v8 00/29] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 01/29] tools/libxc: Remove osdep indirection for xc_evtchn Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 02/29] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn Ian Campbell
2016-01-22 11:48 ` Ian Campbell
2016-01-22 17:12 ` Boris Ostrovsky
2016-01-25 9:48 ` Ian Campbell
2016-01-25 14:35 ` Ian Jackson
2016-01-25 14:39 ` Boris Ostrovsky
2016-01-25 14:47 ` Ian Campbell
2016-01-25 14:49 ` Andrew Cooper
2016-01-25 15:28 ` Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 03/29] tools: Arrange to check public headers for ANSI compatiblity Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 04/29] tools/libxc: Remove osdep indirection for xc_gnt{shr, tab} Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 05/29] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 06/29] tools/libxc: Remove osdep indirection for privcmd Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 07/29] tools: Refactor hypercall calling wrappers into libxencall Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 08/29] tools/libxc: drop xc_map_foreign_bulk_compat wrappers Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 09/29] tools: Remove xc_map_foreign_batch Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 10/29] tools: Implement xc_map_foreign_range(s) in terms of common helper Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory Ian Campbell
2016-01-25 12:01 ` Olaf Hering
2016-01-25 12:31 ` Ian Campbell
2016-01-25 12:44 ` Ian Campbell [this message]
2016-01-25 12:45 ` [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces Ian Campbell
2016-01-25 13:25 ` Tim Deegan
2016-01-25 14:22 ` Ian Campbell
2016-01-25 14:00 ` Olaf Hering
2016-01-25 13:18 ` [PATCH] kdd: build using Werror Ian Campbell
2016-01-25 13:20 ` Olaf Hering
2016-01-25 13:24 ` Ian Campbell
2016-01-25 13:25 ` Tim Deegan
2016-01-25 14:22 ` Ian Campbell
2016-01-25 14:37 ` Olaf Hering
2016-01-15 13:22 ` [PATCH XEN v8 12/29] tools/libs/foreignmemory: provide xenforeignmemory_unmap Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 13/29] tools/libs/foreignmemory: use size_t for size arguments Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 14/29] tools/libs/foreignmemory: Mention restrictions on fork in docs Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-19 13:34 ` Ian Campbell
2016-01-19 14:25 ` Wei Liu
2016-01-15 13:22 ` [PATCH XEN v8 15/29] tools/libs/foreignmemory: Support err == NULL to map Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 16/29] tools/libs/foreignmemory: pull array length argument to map forward Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 17/29] tools/libs/evtchn: Review and update doc comments Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 18/29] tools/libs/evtchn: Use uint32_t for domid arguments Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-15 13:22 ` [PATCH XEN v8 19/29] tools/libs: Clean up hard tabs Ian Campbell
2016-01-15 13:22 ` [PATCH XEN v8 20/29] tools/libs/gnttab: Extensive updates to API documentation Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-15 13:23 ` [PATCH XEN v8 21/29] tools/libs/call: Update some log messages to not refer to xc Ian Campbell
2016-01-15 13:23 ` [PATCH XEN v8 22/29] tools/libs/call: Describe return values and error semantics for xencall* Ian Campbell
2016-01-15 13:23 ` [PATCH XEN v8 23/29] tools/libs/call: Avoid xc_memalign in netbsd and solaris backends Ian Campbell
2016-01-15 13:23 ` [PATCH XEN v8 24/29] tools/libs/call: linux: touch newly allocated pages after madvise lockdown Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-19 13:40 ` Ian Campbell
2016-01-19 14:26 ` Wei Liu
2016-01-19 14:54 ` Roger Pau Monné
2016-01-19 14:58 ` Wei Liu
2016-01-19 15:03 ` Ian Campbell
2016-01-19 15:49 ` Wei Liu
2016-01-19 15:59 ` Ian Campbell
2016-01-15 13:23 ` [PATCH XEN v8 25/29] tools/libs/{call, evtchn}: Document requirements around forking Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-15 13:23 ` [PATCH XEN v8 26/29] tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-15 13:23 ` [PATCH XEN v8 27/29] tools: Update CFLAGS for qemu-xen to allow it to use new libraries Ian Campbell
2016-01-15 13:23 ` [PATCH XEN v8 28/29] tools/libs/*: Introduce APIs to restrict handles to a specific domain Ian Campbell
2016-01-19 13:24 ` Wei Liu
2016-01-19 13:44 ` Ian Campbell
2016-01-19 14:30 ` Wei Liu
2016-01-15 13:23 ` [PATCH XEN v8 29/29] HACK: Update Config.mk to pull all the right bits from my xenbits trees Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 0/8] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
[not found] ` <1452864224-2554-1-git-send-email-ian.campbell@citrix.com>
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 1/8] xen_console: correctly cleanup primary console on teardown Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 2/8] xen: Switch to libxenevtchn interface for compat shims Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 3/8] xen: Switch to libxengnttab " Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 5/8] xen: Switch uses of xc_map_foreign_{pages, bulk} to use libxenforeignmemory API Ian Campbell
2016-01-15 14:43 ` Stefano Stabellini
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 6/8] xen: Use stable library interfaces when they are available Ian Campbell
2016-01-15 14:43 ` Stefano Stabellini
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN v8 8/8] xen: make it possible to build without the Xen PV domain builder Ian Campbell
2016-01-15 14:44 ` [PATCH QEMU-XEN v8 0/8] Begin to disentangle libxenctrl and provide some stable libraries Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1601151443370.16178@kaball.uk.xensource.com>
2016-01-15 15:08 ` Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN-TRADITIONAL v8 0/4] " Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN-TRADITIONAL v8 1/4] qemu-xen-traditional: Use libxenevtchn Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN-TRADITIONAL v8 2/4] qemu-xen-traditional: Use libxengnttab Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN-TRADITIONAL v8 3/4] qemu-xen-traditional: Add libxencall to rpath-link Ian Campbell
2016-01-15 13:23 ` [PATCH QEMU-XEN-TRADITIONAL v8 4/4] qemu-xen-traditional: Add libxenforeignmemory " Ian Campbell
2016-01-15 13:23 ` [PATCH MINI-OS v8 0/4] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2016-01-15 13:24 ` [PATCH MINI-OS v8 1/4] mini-os: Include libxenevtchn with libxc Ian Campbell
2016-01-15 13:24 ` [PATCH MINI-OS v8 2/4] mini-os: Include libxengnttab " Ian Campbell
2016-01-15 13:24 ` [PATCH MINI-OS v8 3/4] mini-os: Include libxencall " Ian Campbell
2016-01-15 13:24 ` [PATCH MINI-OS v8 4/4] mini-os: Include libxenforeignmemory " Ian Campbell
2016-01-19 15:44 ` [Minios-devel] [PATCH v8 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
[not found] ` <1453218278.29930.89.camel@citrix.com>
2016-01-22 10:42 ` Ian Campbell
2016-01-22 14:14 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453725846.4320.150.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).