xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jianzhong,Chang" <changjzh@gmail.com>
To: keir@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xen.org
Cc: "Jianzhong,Chang" <changjzh@gmail.com>
Subject: [PATCH] xen vtd : set msi guest_masked 0 by default
Date: Tue, 26 Jan 2016 09:34:52 +0800	[thread overview]
Message-ID: <1453772092-24866-1-git-send-email-changjzh@gmail.com> (raw)

There are some problems when msi guest_masked is set to 1 by default.
When guest os is windows 2008 r2 server,
the device(eg X540-AT2 vf) is not initialized correctly.
Host will always receive message like this :"VF Reset msg received from vf".
Guest has network connectivity issues,
and can not correctly receive/send the packet.
So, guest_masked is set to 0 by default.

Signed-off-by: Jianzhong,Chang <changjzh@gmail.com>
---
 xen/arch/x86/msi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 5a481f6..b4f60a3 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -512,7 +512,7 @@ void guest_mask_msi_irq(struct irq_desc *desc, bool_t mask)
 
 static unsigned int startup_msi_irq(struct irq_desc *desc)
 {
-    if ( unlikely(!msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST))) )
+    if ( unlikely(!msi_set_mask_bit(desc, 0, 0) ))
         WARN();
     return 0;
 }
@@ -972,7 +972,7 @@ static int msix_capability_init(struct pci_dev *dev,
         entry->msi_attrib.entry_nr = msi->entry_nr;
         entry->msi_attrib.maskbit = 1;
         entry->msi_attrib.host_masked = 1;
-        entry->msi_attrib.guest_masked = 1;
+        entry->msi_attrib.guest_masked = 0;
         entry->msi_attrib.pos = pos;
         entry->irq = msi->irq;
         entry->dev = dev;
-- 
1.7.1

             reply	other threads:[~2016-01-26  1:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  1:34 Jianzhong,Chang [this message]
2016-01-26 12:56 ` [PATCH] xen vtd : set msi guest_masked 0 by default Jan Beulich
2016-01-26 22:24   ` Tian, Kevin
2016-03-07  8:12   ` jzh Chang
2016-03-07 10:57     ` Jan Beulich
2018-05-21 11:46 ` David Woodhouse
2018-05-21 12:10   ` Roger Pau Monné
2018-05-23  7:01     ` David Woodhouse
2018-06-18  9:35       ` [PATCH qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time Andra Paraschiv
2018-06-18 11:43         ` Roger Pau Monné
2018-06-21  8:37           ` Paraschiv, Andra-Irina
2018-07-31 10:22             ` Woodhouse, David
2018-09-17  8:40               ` Paraschiv, Andra-Irina
2018-10-09 13:55                 ` Ian Jackson
2018-10-09 15:23                   ` Paraschiv, Andra-Irina
2018-10-10 14:56                     ` Ian Jackson
2018-10-10 19:06                       ` Paraschiv, Andra-Irina
2018-06-18 10:31       ` xen vtd : set msi guest_masked 0 by default Paraschiv, Andra-Irina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453772092-24866-1-git-send-email-changjzh@gmail.com \
    --to=changjzh@gmail.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).