Re: [PATCH] public/io/netif.h: change semantics of "request-multicast-control" flag

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2016-01-26 at 14:17 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Wei Liu [mailto:wei.liu2@citrix.com]
> > Sent: 21 January 2016 15:46
> > To: Ian Campbell
> > Cc: Paul Durrant; xen-devel@lists.xenproject.org; Ian Jackson; Jan
> > Beulich;
> > Keir (Xen.org); Tim (Xen.org); Wei Liu; Roger Pau Monne
> > Subject: Re: [PATCH] public/io/netif.h: change semantics of "request-
> > multicast-control" flag
> > 
> > On Thu, Jan 21, 2016 at 03:29:36PM +0000, Ian Campbell wrote:
> > > On Wed, 2016-01-20 at 12:50 +0000, Paul Durrant wrote:
> > > > My patch b2700877 "move and amend multicast control documentation"
> > > > clarified use of the multicast control protocol between frontend
> > > > and
> > > > backend. However, it transpires that the restrictions that
> > > > documentation
> > > > placed on the "request-multicast-control" flag make it hard for a
> > > > frontend to enable 'all multicast' promiscuous mode, in that to do
> > > > so
> > > > would require the frontend and backend to disconnect and re-
> > > > connect.
> > > > 
> > > > This patch adds a new "feature-dynamic-multicast-control" flag to
> > > > allow
> > > > a backend to advertise that it will watch "request-multicast-
> > > > control"
> > hence
> > > > allowing it to be meaningfully modified by the frontend at any time
> > > > rather
> > > > than only when the frontend and backend are disconnected.
> > > > 
> > > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > > Cc: Jan Beulich <jbeulich@suse.com>
> > > > Cc: Keir Fraser <keir@xen.org>
> > > > Cc: Tim Deegan <tim@xen.org>
> > > 
> > > 
> > > This looks good to me, but also adding Wei (Linux netback + BSD
> > > stuff) and
> > > Roger (BSD stuff) for their perspective.
> > > 
> > > I should probably have done that for the last set of netif.h changes
> > > too,
> > > since apart from the nominal maintainers of xen/include/public/io/*.h
> > > it's
> > > worth getting input from the maintainers of the consumers. Not sure
> > > we
> > can
> > > express that very well in MAINTAINERS :-(.
> > > 
> > > Ian.
> > 
> > LGTM
> > 
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> Ping? I notice this patch is not yet applied.

I'd have done it yesterday but the machines I needed were offline.

Now done.

> 
>   Paul
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel