From: Ian Campbell <ian.campbell@citrix.com>
To: Chester Lin <czylin@uwaterloo.ca>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
jtotto@uwaterloo.ca, hjarmstr@uwaterloo.ca
Subject: Re: [PATCH v3 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE
Date: Tue, 26 Jan 2016 16:52:30 +0000 [thread overview]
Message-ID: <1453827150.25257.44.camel@citrix.com> (raw)
In-Reply-To: <1453722931.4320.128.camel@citrix.com>
On Mon, 2016-01-25 at 11:55 +0000, Ian Campbell wrote:
> On Sun, 2016-01-24 at 19:45 -0500, Chester Lin wrote:
> > To more closely follow the guidelines in CODING_STYLE, store the result
> > of xc_sched_id() in the local variable r, and the check the result of
> > the call in a separate statement. Change the type of the output
> > parameter given to xc_sched_id() from libxl_scheduler to int to match
> > the libxc interface.
> >
> > Additionally, change the error log statement to more accurately reflect
> > the failure. This is the only functional change introduced by this
> > patch.
> >
> > Suggested-by: Ian Campbell <ian.campbell@citrix.com>
> > Signed-off-by: Chester Lin <czylin@uwaterloo.ca>
> > Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied, thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-01-26 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 0:45 [PATCH v3 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE Chester Lin
2016-01-25 11:55 ` Ian Campbell
2016-01-26 16:52 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453827150.25257.44.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=czylin@uwaterloo.ca \
--cc=dario.faggioli@citrix.com \
--cc=hjarmstr@uwaterloo.ca \
--cc=ian.jackson@eu.citrix.com \
--cc=jtotto@uwaterloo.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).