From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org
Subject: [PATCH RFC] Remove PV superpage support (v1).
Date: Fri, 29 Jan 2016 10:30:45 -0500 [thread overview]
Message-ID: <1454081446-9753-1-git-send-email-konrad.wilk@oracle.com> (raw)
Hey,
This patchset removes the opt_allow_superpage parameter and also the code around it.
I've tested (migration, bootup, etc) with normal PV and HVM guests and all works.
I haven't yet tested kernels that had PV superpage support in (UEK2, UEK3, classic
Xen kernels) but looking at the code it ought to just print in the dmesg:
"Xen hypervisor is not configured to allow hugepages"
and fail when setting up hugepages. That will be tested shortly (hence
the RFC nature).
I am hoping the maintainers can guide me in how they would like:
- Deal with documentation? I removed the allowsuperpage from documentation
but perhaps it should just mention deprecated?
- I left put_superpage as put_page_from_l2e calls it - but I can't see
how the _PAGE_PSE bit would be set as you won't be able to even
put that bit on (after my patch). Perhaps just make it an
ASSERT in put_page_from_l2e?
- With the removal of this some of the code could be made simpler:
if (.. _PAGE_PSE return -EINVAL;
instead of inverse: if (! .._PAGE_PSE) ..
I can make that an follow up patch if desired?
docs/misc/xen-command-line.markdown | 7 --
tools/libxc/include/xenguest.h | 3 +-
tools/libxc/xc_nomigrate.c | 2 +-
tools/libxc/xc_sr_restore.c | 6 +-
tools/libxl/libxl_internal.h | 2 +-
tools/libxl/libxl_save_callout.c | 4 +-
tools/libxl/libxl_save_helper.c | 3 +-
tools/libxl/libxl_stream_read.c | 2 +-
xen/arch/x86/domain.c | 2 -
xen/arch/x86/domain_build.c | 2 -
xen/arch/x86/mm.c | 241 ++----------------------------------
xen/include/asm-x86/config.h | 9 +-
xen/include/asm-x86/guest_pt.h | 4 +-
xen/include/asm-x86/mm.h | 19 ---
xen/include/public/xen.h | 4 +-
15 files changed, 23 insertions(+), 287 deletions(-)
Konrad Rzeszutek Wilk (1):
xen/libxl/libxl: RIP PV superpage.
next reply other threads:[~2016-01-29 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 15:30 Konrad Rzeszutek Wilk [this message]
2016-01-29 15:30 ` [PATCH RFC] xen/libxl/libxl: RIP PV superpage Konrad Rzeszutek Wilk
2016-01-29 16:15 ` Jan Beulich
2016-02-01 10:37 ` Wei Liu
2016-01-29 16:00 ` [PATCH RFC] Remove PV superpage support (v1) Jan Beulich
2016-01-29 16:26 ` Konrad Rzeszutek Wilk
2016-01-29 16:46 ` Jan Beulich
2016-02-01 4:54 ` Juergen Gross
2016-02-01 7:53 ` Jan Beulich
[not found] ` <56AF1D0C02000078000CCBC0@suse.com>
2016-02-01 8:03 ` Juergen Gross
2016-02-01 8:07 ` Jan Beulich
2016-02-01 9:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454081446-9753-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).