From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: david.vrabel@citrix.com, konrad.wilk@oracle.com
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, mcgrof@suse.com,
linux-kernel@vger.kernel.org, roger.pau@citrix.com
Subject: [PATCH v2 10/11] xen/hvmlite: Boot secondary CPUs
Date: Mon, 1 Feb 2016 10:38:56 -0500 [thread overview]
Message-ID: <1454341137-14110-11-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com>
HVMlite secondary VCPUs use baremetal bringup path (i.e. native_*
smp_ops) but need to do some preparation in PV code.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
arch/x86/xen/enlighten.c | 2 +
arch/x86/xen/pmu.c | 4 +-
arch/x86/xen/smp.c | 64 +++++++++++++++++++++++++++++++++------------
3 files changed, 51 insertions(+), 19 deletions(-)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 1409de6..76fb0b2 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1933,6 +1933,8 @@ static void __init xen_hvm_guest_init(void)
xen_have_vector_callback = 1;
xen_hvm_smp_init();
register_cpu_notifier(&xen_hvm_cpu_notifier);
+ if (xen_hvmlite)
+ smp_found_config = 1;
xen_unplug_emulated_devices();
x86_init.irqs.intr_init = xen_init_IRQ;
xen_hvm_init_time_ops();
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 724a087..7bc209b 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -518,7 +518,7 @@ void xen_pmu_init(int cpu)
BUILD_BUG_ON(sizeof(struct xen_pmu_data) > PAGE_SIZE);
- if (xen_hvm_domain())
+ if (xen_hvm_domain() && !xen_hvmlite)
return;
xenpmu_data = (struct xen_pmu_data *)get_zeroed_page(GFP_KERNEL);
@@ -556,7 +556,7 @@ void xen_pmu_finish(int cpu)
{
struct xen_pmu_params xp;
- if (xen_hvm_domain())
+ if (xen_hvm_domain() && !xen_hvmlite)
return;
xp.vcpu = cpu;
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index fb085ef..a22cae2 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -348,26 +348,31 @@ static void __init xen_smp_prepare_cpus(unsigned int max_cpus)
}
xen_init_lock_cpu(0);
- smp_store_boot_cpu_info();
- cpu_data(0).x86_max_cores = 1;
+ if (!xen_hvmlite) {
+ smp_store_boot_cpu_info();
+ cpu_data(0).x86_max_cores = 1;
+
+ for_each_possible_cpu(i) {
+ zalloc_cpumask_var(&per_cpu(cpu_sibling_map, i),
+ GFP_KERNEL);
+ zalloc_cpumask_var(&per_cpu(cpu_core_map, i),
+ GFP_KERNEL);
+ zalloc_cpumask_var(&per_cpu(cpu_llc_shared_map, i),
+ GFP_KERNEL);
+ }
+ set_cpu_sibling_map(0);
- for_each_possible_cpu(i) {
- zalloc_cpumask_var(&per_cpu(cpu_sibling_map, i), GFP_KERNEL);
- zalloc_cpumask_var(&per_cpu(cpu_core_map, i), GFP_KERNEL);
- zalloc_cpumask_var(&per_cpu(cpu_llc_shared_map, i), GFP_KERNEL);
+ if (!alloc_cpumask_var(&xen_cpu_initialized_map, GFP_KERNEL))
+ panic("could not allocate xen_cpu_initialized_map\n");
+
+ cpumask_copy(xen_cpu_initialized_map, cpumask_of(0));
}
- set_cpu_sibling_map(0);
xen_pmu_init(0);
if (xen_smp_intr_init(0))
BUG();
- if (!alloc_cpumask_var(&xen_cpu_initialized_map, GFP_KERNEL))
- panic("could not allocate xen_cpu_initialized_map\n");
-
- cpumask_copy(xen_cpu_initialized_map, cpumask_of(0));
-
/* Restrict the possible_map according to max_cpus. */
while ((num_possible_cpus() > 1) && (num_possible_cpus() > max_cpus)) {
for (cpu = nr_cpu_ids - 1; !cpu_possible(cpu); cpu--)
@@ -375,8 +380,11 @@ static void __init xen_smp_prepare_cpus(unsigned int max_cpus)
set_cpu_possible(cpu, false);
}
- for_each_possible_cpu(cpu)
+ for_each_possible_cpu(cpu) {
set_cpu_present(cpu, true);
+ if (xen_hvmlite)
+ physid_set(cpu, phys_cpu_present_map);
+ }
}
static int
@@ -810,10 +818,15 @@ void __init xen_smp_init(void)
static void __init xen_hvm_smp_prepare_cpus(unsigned int max_cpus)
{
+ if (xen_hvmlite)
+ xen_smp_prepare_cpus(max_cpus);
+
native_smp_prepare_cpus(max_cpus);
- WARN_ON(xen_smp_intr_init(0));
- xen_init_lock_cpu(0);
+ if (!xen_hvmlite) {
+ WARN_ON(xen_smp_intr_init(0));
+ xen_init_lock_cpu(0);
+ }
}
static int xen_hvm_cpu_up(unsigned int cpu, struct task_struct *tidle)
@@ -836,8 +849,21 @@ static int xen_hvm_cpu_up(unsigned int cpu, struct task_struct *tidle)
*/
rc = xen_smp_intr_init(cpu);
WARN_ON(rc);
- if (!rc)
- rc = native_cpu_up(cpu, tidle);
+
+ if (xen_hvmlite) {
+ rc = cpu_initialize_context(cpu, tidle);
+ if (rc) {
+ xen_smp_intr_free(cpu);
+ return rc;
+ }
+ xen_pmu_init(cpu);
+ }
+
+ if (!rc) {
+ rc = native_cpu_up(cpu, tidle);
+ if (rc && xen_hvmlite)
+ xen_pmu_finish(cpu);
+ }
/*
* We must initialize the slowpath CPU kicker _after_ the native
@@ -861,4 +887,8 @@ void __init xen_hvm_smp_init(void)
smp_ops.send_call_func_ipi = xen_smp_send_call_function_ipi;
smp_ops.send_call_func_single_ipi = xen_smp_send_call_function_single_ipi;
smp_ops.smp_prepare_boot_cpu = xen_smp_prepare_boot_cpu;
+ if (xen_hvmlite) {
+ smp_ops.play_dead = xen_play_dead;
+ xen_fill_possible_map();
+ }
}
--
1.7.1
next prev parent reply other threads:[~2016-02-01 15:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:38 [PATCH v2 00/11] HVMlite domU support Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 01/11] xen/hvmlite: Import hvmlite-related Xen public interfaces Boris Ostrovsky
2016-02-02 16:06 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest Boris Ostrovsky
2016-02-02 16:39 ` David Vrabel
[not found] ` <56B0DBD6.3060205@citrix.com>
2016-02-02 17:19 ` Boris Ostrovsky
2016-02-03 18:55 ` Luis R. Rodriguez
[not found] ` <20160203185525.GV20964@wotan.suse.de>
2016-02-03 20:11 ` Boris Ostrovsky
2016-02-03 20:52 ` Andrew Cooper
[not found] ` <56B25F0C.2050808@oracle.com>
2016-02-03 23:40 ` Luis R. Rodriguez
[not found] ` <20160203234026.GS20964@wotan.suse.de>
2016-02-04 19:54 ` Boris Ostrovsky
[not found] ` <56B3AC67.7080704@oracle.com>
2016-02-04 20:57 ` Luis R. Rodriguez
[not found] ` <20160204205721.GJ12481@wotan.suse.de>
2016-02-04 22:28 ` Boris Ostrovsky
[not found] ` <56B268A2.5000704@citrix.com>
2016-02-03 23:59 ` Luis R. Rodriguez
[not found] ` <20160203235908.GT20964@wotan.suse.de>
2016-02-04 0:08 ` Luis R. Rodriguez
2016-02-04 0:51 ` Andrew Cooper
[not found] ` <56B2A09A.70404@citrix.com>
2016-02-04 23:10 ` Luis R. Rodriguez
[not found] ` <20160204231031.GM12481@wotan.suse.de>
2016-04-05 22:02 ` Luis R. Rodriguez
2016-04-24 20:23 ` Borislav Petkov
[not found] ` <20160424202314.GA3973@pd.tnic>
2016-04-25 13:21 ` Boris Ostrovsky
[not found] ` <571E19D7.1080301@oracle.com>
2016-04-25 13:47 ` Borislav Petkov
[not found] ` <20160425134749.GB28454@pd.tnic>
2016-04-25 13:54 ` Boris Ostrovsky
[not found] ` <571E219D.2090308@oracle.com>
2016-04-25 14:11 ` Borislav Petkov
[not found] ` <20160425141145.GE28454@pd.tnic>
2016-04-25 14:42 ` Boris Ostrovsky
[not found] ` <571E2CC7.7080907@oracle.com>
2016-04-25 15:22 ` Borislav Petkov
[not found] ` <20160425152209.GH28454@pd.tnic>
2016-04-25 15:48 ` Boris Ostrovsky
2016-04-26 10:53 ` Borislav Petkov
2016-04-25 17:24 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 03/11] xen/hvmlite: Initialize HVMlite kernel Boris Ostrovsky
2016-02-17 20:08 ` Luis R. Rodriguez
2016-02-01 15:38 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 05/11] xen/hvmlite: HVMlite guests always have PV devices Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 06/11] xen/hvmlite: Prepare cpu_initialize_context() routine for HVMlite SMP Boris Ostrovsky
2016-02-02 16:16 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Boris Ostrovsky
2016-02-02 16:21 ` David Vrabel
[not found] ` <56B0D786.7000002@citrix.com>
2016-02-02 16:58 ` Boris Ostrovsky
[not found] ` <56B0E046.6050900@oracle.com>
2016-02-04 10:07 ` David Vrabel
2016-02-04 12:58 ` Doug Goldstein
[not found] ` <56B34B01.50000@cardoe.com>
2016-02-04 19:08 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests Boris Ostrovsky
2016-02-04 10:04 ` David Vrabel
[not found] ` <56B32220.4040505@citrix.com>
2016-02-04 12:14 ` Roger Pau Monné
[not found] ` <56B340B4.3050406@citrix.com>
2016-02-04 14:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init " Boris Ostrovsky
2016-02-02 16:27 ` David Vrabel
[not found] ` <56B0D8DD.5010206@citrix.com>
2016-02-02 17:01 ` Boris Ostrovsky
2016-02-01 15:38 ` Boris Ostrovsky [this message]
2016-02-04 10:38 ` [PATCH v2 10/11] xen/hvmlite: Boot secondary CPUs David Vrabel
[not found] ` <56B32A29.6050406@citrix.com>
2016-02-04 13:51 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 11/11] xen/hvmlite: Enable CPU on-/offlining Boris Ostrovsky
[not found] ` <1454341137-14110-5-git-send-email-boris.ostrovsky@oracle.com>
2016-02-02 16:13 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table David Vrabel
[not found] ` <56B0D596.4050301@citrix.com>
2016-02-02 16:49 ` Boris Ostrovsky
2016-02-03 18:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454341137-14110-11-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).