From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: david.vrabel@citrix.com, konrad.wilk@oracle.com
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, mcgrof@suse.com,
linux-kernel@vger.kernel.org, roger.pau@citrix.com
Subject: [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests
Date: Mon, 1 Feb 2016 10:38:54 -0500 [thread overview]
Message-ID: <1454341137-14110-9-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com>
HVMlite guests need to be viewed as having APIC, otherwise smpboot code,
for example, will complain.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
Not sure about xen_cpu_present_to_apicid() being an identity function, given
xen_x86_32_early_logical_apicid().
Suspend/resume will cause xen_apic_write() warnings.
arch/x86/xen/apic.c | 39 +++++++++++++++++++++++++++++++++++++--
arch/x86/xen/smp.c | 2 +-
2 files changed, 38 insertions(+), 3 deletions(-)
diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
index acda713..9bf27f2 100644
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -6,6 +6,7 @@
#include <xen/xen.h>
#include <xen/interface/physdev.h>
+#include <xen/interface/vcpu.h>
#include "xen-ops.h"
#include "pmu.h"
#include "smp.h"
@@ -78,6 +79,21 @@ static void xen_apic_write(u32 reg, u32 val)
return;
}
+ if (xen_hvmlite) {
+ switch (reg) {
+ case APIC_TASKPRI:
+ case APIC_SPIV:
+ case APIC_ESR:
+ case APIC_LVTT:
+ case APIC_LVT0:
+ case APIC_LVT1:
+ case APIC_LVTERR:
+ pr_debug("Unimplemented APIC register %x,"
+ " value: %x\n", reg, val);
+ return;
+ }
+ }
+
/* Warn to see if there's any stray references */
WARN(1,"register: %x, value: %x\n", reg, val);
}
@@ -100,7 +116,7 @@ static u32 xen_safe_apic_wait_icr_idle(void)
static int xen_apic_probe_pv(void)
{
- if (xen_pv_domain())
+ if (xen_pv_domain() || xen_hvmlite)
return 1;
return 0;
@@ -142,6 +158,19 @@ static void xen_silent_inquire(int apicid)
{
}
+static int xen_cpu_present_to_apicid(int cpu)
+{
+ return cpu;
+}
+
+static int xen_wakeup_secondary_cpu(int cpu, unsigned long start_eip)
+{
+ if (!xen_hvmlite)
+ return -EINVAL;
+
+ return HYPERVISOR_vcpu_op(VCPUOP_up, cpu, NULL);
+}
+
static struct apic xen_pv_apic = {
.name = "Xen PV",
.probe = xen_apic_probe_pv,
@@ -162,7 +191,7 @@ static struct apic xen_pv_apic = {
.ioapic_phys_id_map = default_ioapic_phys_id_map, /* Used on 32-bit */
.setup_apic_routing = NULL,
- .cpu_present_to_apicid = default_cpu_present_to_apicid,
+ .cpu_present_to_apicid = xen_cpu_present_to_apicid,
.apicid_to_cpu_present = physid_set_mask_of_physid, /* Used on 32-bit */
.check_phys_apicid_present = default_check_phys_apicid_present, /* smp_sanity_check needs it */
.phys_pkg_id = xen_phys_pkg_id, /* detect_ht */
@@ -180,6 +209,9 @@ static struct apic xen_pv_apic = {
.send_IPI_all = xen_send_IPI_all,
.send_IPI_self = xen_send_IPI_self,
#endif
+
+ .wakeup_secondary_cpu = xen_wakeup_secondary_cpu,
+
/* .wait_for_init_deassert- used by AP bootup - smp_callin which we don't use */
.inquire_remote_apic = xen_silent_inquire,
@@ -216,5 +248,8 @@ void __init xen_init_apic(void)
apic = &xen_pv_apic;
x86_platform.apic_post_init = xen_apic_check;
+
+ if (xen_hvmlite)
+ setup_force_cpu_cap(X86_FEATURE_APIC);
}
apic_driver(xen_pv_apic);
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index b265c4f..fb085ef 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -214,7 +214,7 @@ static int xen_smp_intr_init(unsigned int cpu)
* The IRQ worker on PVHVM goes through the native path and uses the
* IPI mechanism.
*/
- if (xen_hvm_domain())
+ if (xen_hvm_domain() && !xen_hvmlite)
return 0;
callfunc_name = kasprintf(GFP_KERNEL, "irqwork%d", cpu);
--
1.7.1
next prev parent reply other threads:[~2016-02-01 15:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:38 [PATCH v2 00/11] HVMlite domU support Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 01/11] xen/hvmlite: Import hvmlite-related Xen public interfaces Boris Ostrovsky
2016-02-02 16:06 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest Boris Ostrovsky
2016-02-02 16:39 ` David Vrabel
[not found] ` <56B0DBD6.3060205@citrix.com>
2016-02-02 17:19 ` Boris Ostrovsky
2016-02-03 18:55 ` Luis R. Rodriguez
[not found] ` <20160203185525.GV20964@wotan.suse.de>
2016-02-03 20:11 ` Boris Ostrovsky
2016-02-03 20:52 ` Andrew Cooper
[not found] ` <56B25F0C.2050808@oracle.com>
2016-02-03 23:40 ` Luis R. Rodriguez
[not found] ` <20160203234026.GS20964@wotan.suse.de>
2016-02-04 19:54 ` Boris Ostrovsky
[not found] ` <56B3AC67.7080704@oracle.com>
2016-02-04 20:57 ` Luis R. Rodriguez
[not found] ` <20160204205721.GJ12481@wotan.suse.de>
2016-02-04 22:28 ` Boris Ostrovsky
[not found] ` <56B268A2.5000704@citrix.com>
2016-02-03 23:59 ` Luis R. Rodriguez
[not found] ` <20160203235908.GT20964@wotan.suse.de>
2016-02-04 0:08 ` Luis R. Rodriguez
2016-02-04 0:51 ` Andrew Cooper
[not found] ` <56B2A09A.70404@citrix.com>
2016-02-04 23:10 ` Luis R. Rodriguez
[not found] ` <20160204231031.GM12481@wotan.suse.de>
2016-04-05 22:02 ` Luis R. Rodriguez
2016-04-24 20:23 ` Borislav Petkov
[not found] ` <20160424202314.GA3973@pd.tnic>
2016-04-25 13:21 ` Boris Ostrovsky
[not found] ` <571E19D7.1080301@oracle.com>
2016-04-25 13:47 ` Borislav Petkov
[not found] ` <20160425134749.GB28454@pd.tnic>
2016-04-25 13:54 ` Boris Ostrovsky
[not found] ` <571E219D.2090308@oracle.com>
2016-04-25 14:11 ` Borislav Petkov
[not found] ` <20160425141145.GE28454@pd.tnic>
2016-04-25 14:42 ` Boris Ostrovsky
[not found] ` <571E2CC7.7080907@oracle.com>
2016-04-25 15:22 ` Borislav Petkov
[not found] ` <20160425152209.GH28454@pd.tnic>
2016-04-25 15:48 ` Boris Ostrovsky
2016-04-26 10:53 ` Borislav Petkov
2016-04-25 17:24 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 03/11] xen/hvmlite: Initialize HVMlite kernel Boris Ostrovsky
2016-02-17 20:08 ` Luis R. Rodriguez
2016-02-01 15:38 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 05/11] xen/hvmlite: HVMlite guests always have PV devices Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 06/11] xen/hvmlite: Prepare cpu_initialize_context() routine for HVMlite SMP Boris Ostrovsky
2016-02-02 16:16 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Boris Ostrovsky
2016-02-02 16:21 ` David Vrabel
[not found] ` <56B0D786.7000002@citrix.com>
2016-02-02 16:58 ` Boris Ostrovsky
[not found] ` <56B0E046.6050900@oracle.com>
2016-02-04 10:07 ` David Vrabel
2016-02-04 12:58 ` Doug Goldstein
[not found] ` <56B34B01.50000@cardoe.com>
2016-02-04 19:08 ` Boris Ostrovsky
2016-02-01 15:38 ` Boris Ostrovsky [this message]
2016-02-04 10:04 ` [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests David Vrabel
[not found] ` <56B32220.4040505@citrix.com>
2016-02-04 12:14 ` Roger Pau Monné
[not found] ` <56B340B4.3050406@citrix.com>
2016-02-04 14:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init " Boris Ostrovsky
2016-02-02 16:27 ` David Vrabel
[not found] ` <56B0D8DD.5010206@citrix.com>
2016-02-02 17:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 10/11] xen/hvmlite: Boot secondary CPUs Boris Ostrovsky
2016-02-04 10:38 ` David Vrabel
[not found] ` <56B32A29.6050406@citrix.com>
2016-02-04 13:51 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 11/11] xen/hvmlite: Enable CPU on-/offlining Boris Ostrovsky
[not found] ` <1454341137-14110-5-git-send-email-boris.ostrovsky@oracle.com>
2016-02-02 16:13 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table David Vrabel
[not found] ` <56B0D596.4050301@citrix.com>
2016-02-02 16:49 ` Boris Ostrovsky
2016-02-03 18:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454341137-14110-9-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).