xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libxl: Add CPU hotplug support for HVM domains without device model
@ 2016-02-02 21:02 Boris Ostrovsky
  2016-02-03 10:10 ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Boris Ostrovsky @ 2016-02-02 21:02 UTC (permalink / raw)
  To: ian.jackson, stefano.stabellini, ian.campbell, wei.liu2
  Cc: Boris Ostrovsky, roger.pau, xen-devel

HVMlite domains add/remove VCPUs by toggling "availability" property in
xenstore.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 tools/libxl/libxl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 94b5656..ae8bbd8 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5557,6 +5557,7 @@ int libxl_set_vcpuonline(libxl_ctx *ctx, uint32_t domid, libxl_bitmap *cpumap)
     case LIBXL_DOMAIN_TYPE_HVM:
         switch (libxl__device_model_version_running(gc, domid)) {
         case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL:
+        case LIBXL_DEVICE_MODEL_VERSION_NONE:
             rc = libxl__set_vcpuonline_xenstore(gc, domid, cpumap, &info);
             break;
         case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: Add CPU hotplug support for HVM domains without device model
  2016-02-02 21:02 [PATCH] libxl: Add CPU hotplug support for HVM domains without device model Boris Ostrovsky
@ 2016-02-03 10:10 ` Wei Liu
  2016-02-03 11:49   ` Ian Campbell
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2016-02-03 10:10 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: wei.liu2, ian.campbell, stefano.stabellini, ian.jackson,
	xen-devel, roger.pau

On Tue, Feb 02, 2016 at 04:02:12PM -0500, Boris Ostrovsky wrote:
> HVMlite domains add/remove VCPUs by toggling "availability" property in
> xenstore.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

If this is how it is supposed to work:

Acked-by: Wei Liu <wei.liu2@citrix.com>

However, I would like to ask for a follow-up patch to documentation
xen.git hvmlite.markdown (or whichever file you see fit).

> ---
>  tools/libxl/libxl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 94b5656..ae8bbd8 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -5557,6 +5557,7 @@ int libxl_set_vcpuonline(libxl_ctx *ctx, uint32_t domid, libxl_bitmap *cpumap)
>      case LIBXL_DOMAIN_TYPE_HVM:
>          switch (libxl__device_model_version_running(gc, domid)) {
>          case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL:
> +        case LIBXL_DEVICE_MODEL_VERSION_NONE:
>              rc = libxl__set_vcpuonline_xenstore(gc, domid, cpumap, &info);
>              break;
>          case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: Add CPU hotplug support for HVM domains without device model
  2016-02-03 10:10 ` Wei Liu
@ 2016-02-03 11:49   ` Ian Campbell
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2016-02-03 11:49 UTC (permalink / raw)
  To: Wei Liu, Boris Ostrovsky
  Cc: xen-devel, ian.jackson, roger.pau, stefano.stabellini

On Wed, 2016-02-03 at 10:10 +0000, Wei Liu wrote:
> On Tue, Feb 02, 2016 at 04:02:12PM -0500, Boris Ostrovsky wrote:
> > HVMlite domains add/remove VCPUs by toggling "availability" property in
> > xenstore.
> > 
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> If this is how it is supposed to work:
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied.

> However, I would like to ask for a follow-up patch to documentation
> xen.git hvmlite.markdown (or whichever file you see fit).

Yes, please.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-03 11:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 21:02 [PATCH] libxl: Add CPU hotplug support for HVM domains without device model Boris Ostrovsky
2016-02-03 10:10 ` Wei Liu
2016-02-03 11:49   ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).