From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH] tools: libxencall/foreignmemory: initialise handle->fd Date: Wed, 3 Feb 2016 10:09:42 +0000 Message-ID: <1454494182-14767-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org Otherwise the osdep close on the error path touches an uninitialised varialble. CID: 1351231 (foreignmemory) and 1351230 (call) Signed-off-by: Ian Campbell --- tools/libs/call/core.c | 2 ++ tools/libs/foreignmemory/core.c | 1 + 2 files changed, 3 insertions(+) diff --git a/tools/libs/call/core.c b/tools/libs/call/core.c index bbf88de..5ca0372 100644 --- a/tools/libs/call/core.c +++ b/tools/libs/call/core.c @@ -24,6 +24,8 @@ xencall_handle *xencall_open(xentoollog_logger *logger, unsigned open_flags) if (!xcall) return NULL; + xcall->fd = -1; + xcall->flags = open_flags; xcall->buffer_cache_nr = 0; diff --git a/tools/libs/foreignmemory/core.c b/tools/libs/foreignmemory/core.c index cfb0a73..6591888 100644 --- a/tools/libs/foreignmemory/core.c +++ b/tools/libs/foreignmemory/core.c @@ -27,6 +27,7 @@ xenforeignmemory_handle *xenforeignmemory_open(xentoollog_logger *logger, if (!fmem) return NULL; + fmem->fd = -1; fmem->logger = logger; fmem->logger_tofree = NULL; -- 2.1.4