Leak in xc_dom_load_hvm_kernel() (Was; Re: New Defects reported by Coverity Scan for XenProject)

[Ian Campbell <ian.campbell@citrix.com>]

Roger,

On Tue, 2016-02-02 at 20:23 -0800, scan-admin@coverity.com wrote:
> ** CID 1351227:    (RESOURCE_LEAK)
> /tools/libxc/xc_dom_hvmloader.c: 260 in xc_dom_load_hvm_kernel()
> /tools/libxc/xc_dom_hvmloader.c: 270 in xc_dom_load_hvm_kernel()
> /tools/libxc/xc_dom_hvmloader.c: 277 in xc_dom_load_hvm_kernel()

Looks like this came from ad787bafcd2a3058f0f37f2fe84931bd5136bde9?

> ________________________________________________________________________________________________________
> *** CID 1351227:    (RESOURCE_LEAK)
> /tools/libxc/xc_dom_hvmloader.c: 260 in xc_dom_load_hvm_kernel()
> 254         elf->dest_size = pages * XC_DOM_PAGE_SIZE(dom);
> 255     
> 256         rc = elf_load_binary(elf);
> 257         if ( rc < 0 )
> 258         {
> 259             DOMPRINTF("%s: failed to load elf binary", __func__);
> >>>     CID 1351227:    (RESOURCE_LEAK)
> >>>     Variable "entries" going out of scope leaks the storage it points to.
> 260             return rc;
> 261         }
> 262     
> 263         munmap(elf->dest_base, elf->dest_size);
> 264     
> 265         rc = modules_init(dom, dom->total_pages << PAGE_SHIFT, elf, &m_start,
> /tools/libxc/xc_dom_hvmloader.c: 270 in xc_dom_load_hvm_kernel()
> 264     
> 265         rc = modules_init(dom, dom->total_pages << PAGE_SHIFT, elf, &m_start,
> 266                           &m_end);
> 267         if ( rc != 0 )
> 268         {
> 269             DOMPRINTF("%s: insufficient space to load modules.", __func__);
> >>>     CID 1351227:    (RESOURCE_LEAK)
> >>>     Variable "entries" going out of scope leaks the storage it points to.
> 270             return rc;
> 271         }
> 272     
> 273         rc = loadmodules(dom, m_start, m_end, dom->guest_domid);
> 274         if ( rc != 0 )
> 275         {
> /tools/libxc/xc_dom_hvmloader.c: 277 in xc_dom_load_hvm_kernel()
> 271         }
> 272     
> 273         rc = loadmodules(dom, m_start, m_end, dom->guest_domid);
> 274         if ( rc != 0 )
> 275         {
> 276             DOMPRINTF("%s: unable to load modules.", __func__);
> >>>     CID 1351227:    (RESOURCE_LEAK)
> >>>     Variable "entries" going out of scope leaks the storage it points to.
> 277             return rc;
> 278         }
> 279     
> 280         dom->parms.phys_entry = elf_uval(elf, elf->ehdr, e_entry);
> 281     
> 282         free(entries);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel