From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject) Date: Wed, 3 Feb 2016 10:47:37 +0000 Message-ID: <1454496457.25207.56.camel@citrix.com> References: <56b180c017d5f_214fb5b3143623f@ss1435.mail> <1454496349.25207.54.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1454496349.25207.54.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Malcolm Crossley Cc: George Dunlap , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE2LTAyLTAzIGF0IDEwOjQ1ICswMDAwLCBJYW4gQ2FtcGJlbGwgd3JvdGU6Cj4g T24gVHVlLCAyMDE2LTAyLTAyIGF0IDIwOjIzIC0wODAwLCBzY2FuLWFkbWluQGNvdmVyaXR5LmNv bSB3cm90ZToKPiA+ICogQ0lEIDEzNTEyMjM6wqAgQ29uY3VycmVudCBkYXRhIGFjY2VzcyB2aW9s YXRpb25zwqAgKE1JU1NJTkdfTE9DSykKPiA+IC94ZW4vaW5jbHVkZS94ZW4vc3BpbmxvY2suaDog MzYyIGluIF9wZXJjcHVfd3JpdGVfdW5sb2NrKCkKPiAKPiBDb3Zlcml0eSBzZWVtcyB0byB0aGlu ayB0aGlzIGlzIG5ldyBpbsKgNDFiMGFhNTY5YWRiLi45OTM3NzYzMjY1ZCwKPiBwcmVzdW1hYmx5 IGR1ZSB0b8KgCj4gCj4gY29tbWl0IGY5ZGQ0M2RkZGMwYTMxYTQzNDNhNTgwNzI5MzVjMWI1YzBj YmJlZQo+IEF1dGhvcjogTWFsY29sbSBDcm9zc2xleSA8bWFsY29sbS5jcm9zc2xleUBjaXRyaXgu Y29tPgo+IERhdGU6wqDCoMKgRnJpIEphbiAyMiAxNjowNDo0MSAyMDE2ICswMTAwCj4gCj4gwqDC oMKgwqByd2xvY2s6IGFkZCBwZXItY3B1IHJlYWRlci13cml0ZXIgbG9jayBpbmZyYXN0cnVjdHVy ZQoKSXQgYWxzbyByZXBvcnRzIHRoaXMgb25lLCBidXQgSSBzdXBwb3NlIHRoaXMgaXMgYSBmYWxz ZSArdmUgZ2l2ZW4gdGhlIG5hbWUKb2YgdGhlIGZ1bmN0aW9uLgoKKEFsc28gbm90ZSAic2ltdWxh dGVub3VzbHkiIHNob3VsZCBiZSAic2ltdWx0YW5lb3VzbHkiKQoKICAgICoqIENJRCAxMzUxMjIw OsKgwqBQcm9ncmFtIGhhbmdzwqDCoChMT0NLKQogICAgL3hlbi9pbmNsdWRlL3hlbi9zcGlubG9j ay5oOiAzMTAgaW4gX3BlcmNwdV9yZWFkX2xvY2soKQoKCiAgICBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwogICAgKioqIENJRCAxMzUxMjIwOsKgwqBQcm9n cmFtIGhhbmdzwqDCoChMT0NLKQogICAgL3hlbi9pbmNsdWRlL3hlbi9zcGlubG9jay5oOiAzMTAg aW4gX3BlcmNwdV9yZWFkX2xvY2soKQogICAgMzA0wqDCoMKgwqDCoMKgwqDCoMKgwqAqIERldGVj dCB1c2luZyBhIHNlY29uZCBwZXJjcHVfcndsb2NrX3Qgc2ltdWxhdGVub3VzbHkgYW5kIGZhbGxi YWNrCiAgICAzMDXCoMKgwqDCoMKgwqDCoMKgwqDCoCogdG8gc3RhbmRhcmQgcmVhZF9sb2NrLgog ICAgMzA2wqDCoMKgwqDCoMKgwqDCoMKgwqAqLwogICAgMzA3wqDCoMKgwqDCoMKgwqDCoMKgaWYg KCB1bmxpa2VseSh0aGlzX2NwdV9wdHIocGVyX2NwdWRhdGEpICE9IE5VTEwgKSApCiAgICAzMDjC oMKgwqDCoMKgwqDCoMKgwqB7CiAgICAzMDnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJlYWRf bG9jaygmcGVyY3B1X3J3bG9jay0+cndsb2NrKTsKICAgID4+PsKgwqDCoMKgwqBDSUQgMTM1MTIy MDrCoMKgUHJvZ3JhbSBoYW5nc8KgwqAoTE9DSykKICAgID4+PsKgwqDCoMKgwqBSZXR1cm5pbmcg d2l0aG91dCB1bmxvY2tpbmcgInBlcmNwdV9yd2xvY2stPnJ3bG9jayIuCiAgICAzMTDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybjsKICAgIDMxMcKgwqDCoMKgwqDCoMKgwqDCoH0KICAg IDMxMsKgwqDCoMKgwqAKICAgIDMxM8KgwqDCoMKgwqDCoMKgwqDCoC8qIEluZGljYXRlIHRoaXMg Y3B1IGlzIHJlYWRpbmcuICovCiAgICAzMTTCoMKgwqDCoMKgwqDCoMKgwqB0aGlzX2NwdV9wdHIo cGVyX2NwdWRhdGEpID0gcGVyY3B1X3J3bG9jazsKICAgIDMxNcKgwqDCoMKgwqDCoMKgwqDCoHNt cF9tYigpOwoKCj4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gX18KPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+ICoqKiBDSUQgMTM1MTIyMzrCoCBDb25jdXJyZW50IGRhdGEg YWNjZXNzIHZpb2xhdGlvbnPCoCAoTUlTU0lOR19MT0NLKQo+ID4gL3hlbi9pbmNsdWRlL3hlbi9z cGlubG9jay5oOiAzNjIgaW4gX3BlcmNwdV93cml0ZV91bmxvY2soKQo+ID4gMzU2wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwZXJjcHVfcndsb2NrX3QgKnBlcmNwdV9y d2xvY2spCj4gPiAzNTfCoMKgwqDCoCB7Cj4gPiAzNTjCoMKgwqDCoMKgwqDCoMKgIC8qIFZhbGlk YXRlIHRoZSBjb3JyZWN0IHBlcl9jcHVkYXRhIHZhcmlhYmxlIGhhcyBiZWVuCj4gPiBwcm92aWRl ZC4gKi8KPiA+IDM1OcKgwqDCoMKgwqDCoMKgwqAgX3BlcmNwdV9yd2xvY2tfb3duZXJfY2hlY2so cGVyX2NwdWRhdGEsIHBlcmNwdV9yd2xvY2spOwo+ID4gMzYwwqDCoMKgwqAgCj4gPiAzNjHCoMKg wqDCoMKgwqDCoMKgIEFTU0VSVChwZXJjcHVfcndsb2NrLT53cml0ZXJfYWN0aXZhdGluZyk7Cj4g PiA+ID4gPiDCoMKgwqDCoCBDSUQgMTM1MTIyMzrCoCBDb25jdXJyZW50IGRhdGEgYWNjZXNzIHZp b2xhdGlvbnPCoAo+ID4gPiA+ID4gKE1JU1NJTkdfTE9DSykKPiA+ID4gPiA+IMKgwqDCoMKgIEFj Y2Vzc2luZyAicGVyY3B1X3J3bG9jay0+d3JpdGVyX2FjdGl2YXRpbmciIHdpdGhvdXQgaG9sZGlu Zwo+ID4gPiA+ID4gbG9jawo+ID4gInBlcmNwdV9yd2xvY2sucndsb2NrIi4gRWxzZXdoZXJlLCAi cGVyY3B1X3J3bG9jay53cml0ZXJfYWN0aXZhdGluZyIgaXMKPiA+IGFjY2Vzc2VkIHdpdGggInBl cmNwdV9yd2xvY2sucndsb2NrIiBoZWxkIDEgb3V0IG9mIDIgdGltZXMgKDEgb2YgdGhlc2UKPiA+ IGFjY2Vzc2VzIHN0cm9uZ2x5IGltcGx5IHRoYXQgaXQgaXMgbmVjZXNzYXJ5KS4KPiA+IDM2MsKg wqDCoMKgwqDCoMKgwqAgcGVyY3B1X3J3bG9jay0+d3JpdGVyX2FjdGl2YXRpbmcgPSAwOwo+ID4g MzYzwqDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2soJnBlcmNwdV9yd2xvY2stPnJ3bG9jayk7 Cj4gPiAzNjTCoMKgwqDCoCB9Cj4gPiAzNjXCoMKgwqDCoCAKPiA+IDM2NsKgwqDCoMKgICNkZWZp bmUgcGVyY3B1X3J3X2lzX3dyaXRlX2xvY2tlZChsKcKgwqDCoMKgwqDCoMKgwqAKPiA+IF9yd19p c193cml0ZV9sb2NrZWQoJigobCktPnJ3bG9jaykpCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=