* [PATCH] xenstore: add stddef.h to xenstore_lib.h
@ 2016-01-27 17:06 Ian Campbell
2016-01-28 10:37 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2016-01-27 17:06 UTC (permalink / raw)
To: ian.jackson, wei.liu2, xen-devel; +Cc: Ian Campbell
xs_perm_to_string takes a size_t which isn't defined by anything
pulled in directly by this header.
Given the other headers xenstore_lib.h pulls in this looks to be an
oversight rather than a deliberate policy.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/xenstore/include/xenstore_lib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/xenstore/include/xenstore_lib.h b/tools/xenstore/include/xenstore_lib.h
index 5a10c6c..462b7b9 100644
--- a/tools/xenstore/include/xenstore_lib.h
+++ b/tools/xenstore/include/xenstore_lib.h
@@ -19,6 +19,7 @@
#ifndef XENSTORE_LIB_H
#define XENSTORE_LIB_H
+#include <stddef.h>
#include <stdbool.h>
#include <limits.h>
#include <errno.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xenstore: add stddef.h to xenstore_lib.h
2016-01-27 17:06 [PATCH] xenstore: add stddef.h to xenstore_lib.h Ian Campbell
@ 2016-01-28 10:37 ` Wei Liu
2016-02-03 11:50 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2016-01-28 10:37 UTC (permalink / raw)
To: Ian Campbell; +Cc: wei.liu2, ian.jackson, xen-devel
On Wed, Jan 27, 2016 at 05:06:09PM +0000, Ian Campbell wrote:
> xs_perm_to_string takes a size_t which isn't defined by anything
> pulled in directly by this header.
>
> Given the other headers xenstore_lib.h pulls in this looks to be an
> oversight rather than a deliberate policy.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xenstore: add stddef.h to xenstore_lib.h
2016-01-28 10:37 ` Wei Liu
@ 2016-02-03 11:50 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2016-02-03 11:50 UTC (permalink / raw)
To: Wei Liu; +Cc: ian.jackson, xen-devel
On Thu, 2016-01-28 at 10:37 +0000, Wei Liu wrote:
> On Wed, Jan 27, 2016 at 05:06:09PM +0000, Ian Campbell wrote:
> > xs_perm_to_string takes a size_t which isn't defined by anything
> > pulled in directly by this header.
> >
> > Given the other headers xenstore_lib.h pulls in this looks to be an
> > oversight rather than a deliberate policy.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied,thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-03 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 17:06 [PATCH] xenstore: add stddef.h to xenstore_lib.h Ian Campbell
2016-01-28 10:37 ` Wei Liu
2016-02-03 11:50 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).