xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Alex Braunegg <alex.braunegg@gmail.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl/libxl_dm.c: Enable websocket functionality
Date: Thu, 4 Feb 2016 10:50:46 +0000	[thread overview]
Message-ID: <1454583046.25207.162.camel@citrix.com> (raw)
In-Reply-To: <56b27623.954b620a.b9ec7.ffff96d4@mx.google.com>

On Thu, 2016-02-04 at 08:50 +1100, Alex Braunegg wrote:
> A better solution however in my mind would be to store the websocket & x509
> path in the .cfg file for each virtual machine:

Correct. This would involve adding the appropriate fields to the struct(s)
in tools/libxl/libxl_types.idl, populating them from the xl cfg parser
(xl_cmdimple.c) and obeying them in the code you have patched above.

Please also see http://wiki.xen.org/wiki/Submitting_Xen_Patches for
guidance on submitting patches to Xen, in particular the requirement for a
Signed-off-by (and what that means).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-02-04 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 21:50 [PATCH] libxl/libxl_dm.c: Enable websocket functionality Alex Braunegg
2016-02-04 10:50 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454583046.25207.162.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=alex.braunegg@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).