xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 2/3] xen/init: Drop invbool_param()
Date: Mon, 8 Feb 2016 17:07:46 +0000	[thread overview]
Message-ID: <1454951267-30034-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1454951267-30034-1-git-send-email-andrew.cooper3@citrix.com>

There are now no users.  No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Ian Campbell <Ian.Campbell@citrix.com>
---
 xen/common/kernel.c    | 3 +--
 xen/include/xen/init.h | 5 -----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/xen/common/kernel.c b/xen/common/kernel.c
index 6a3196a..af6e563 100644
--- a/xen/common/kernel.c
+++ b/xen/common/kernel.c
@@ -121,12 +121,11 @@ void __init cmdline_parse(const char *cmdline)
                     simple_strtoll(optval, NULL, 0));
                 break;
             case OPT_BOOL:
-            case OPT_INVBOOL:
                 if ( !parse_bool(optval) )
                     bool_assert = !bool_assert;
                 assign_integer_param(
                     param,
-                    (param->type == OPT_BOOL) == bool_assert);
+                    bool_assert);
                 break;
             case OPT_SIZE:
                 assign_integer_param(
diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h
index 7072013..6081102 100644
--- a/xen/include/xen/init.h
+++ b/xen/include/xen/init.h
@@ -78,7 +78,6 @@ struct kernel_param {
         OPT_STR,
         OPT_UINT,
         OPT_BOOL,
-        OPT_INVBOOL,
         OPT_SIZE,
         OPT_CUSTOM
     } type;
@@ -98,10 +97,6 @@ extern struct kernel_param __setup_start, __setup_end;
     __setup_str __setup_str_##_var[] = _name; \
     __kparam __setup_##_var = \
         { __setup_str_##_var, OPT_BOOL, &_var, sizeof(_var) }
-#define invbool_param(_name, _var) \
-    __setup_str __setup_str_##_var[] = _name; \
-    __kparam __setup_##_var = \
-        { __setup_str_##_var, OPT_INVBOOL, &_var, sizeof(_var) }
 #define integer_param(_name, _var) \
     __setup_str __setup_str_##_var[] = _name; \
     __kparam __setup_##_var = \
-- 
2.1.4

  reply	other threads:[~2016-02-08 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 17:07 [PATCH 1/3] xen/x86: Drop the uses of invbool_param() Andrew Cooper
2016-02-08 17:07 ` Andrew Cooper [this message]
2016-02-09 12:47   ` [PATCH 2/3] xen/init: Drop invbool_param() Jan Beulich
2016-02-08 17:07 ` [PATCH 3/3] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-02-09 12:43   ` Jan Beulich
2016-02-09 13:52     ` Andrew Cooper
2016-02-09 14:32       ` Jan Beulich
2016-02-09 14:40         ` Andrew Cooper
2016-02-09 14:50           ` Jan Beulich
2016-02-22 16:36   ` Jan Beulich
2016-02-22 16:41     ` Andrew Cooper
2016-02-22 18:43     ` Doug Goldstein
2016-02-23  8:07       ` Jan Beulich
2016-02-09 12:46 ` [PATCH 1/3] xen/x86: Drop the uses of invbool_param() Jan Beulich
2016-02-11  9:58   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454951267-30034-2-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).