From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: sched: get rid of static private schedulers' structures Date: Tue, 9 Feb 2016 13:25:34 +0100 Message-ID: <1455020734.3148.67.camel@citrix.com> References: <20160208131916.27675.143.stgit@Solace.station> <56B9DB1D02000078000CFFCA@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8274346803888072294==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aT7MR-0003r8-SF for xen-devel@lists.xenproject.org; Tue, 09 Feb 2016 12:25:39 +0000 In-Reply-To: <56B9DB1D02000078000CFFCA@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Juergen Gross , xen-devel@lists.xenproject.org, George Dunlap List-Id: xen-devel@lists.xenproject.org --===============8274346803888072294== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vTY7nrhxjM3cGW8l7348" --=-vTY7nrhxjM3cGW8l7348 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-02-09 at 04:27 -0700, Jan Beulich wrote: > > > > On 08.02.16 at 14:19, wrote: > > @@ -1995,13 +1996,11 @@ static void csched_tick_resume(const struct > > scheduler *ops, unsigned int cpu) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0- now % MICROSECS(prv->tick_period_us) ); > > =C2=A0} > > =C2=A0 > > -static struct csched_private _csched_priv; > > - > > =C2=A0static const struct scheduler sched_credit_def =3D { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.name=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D "SMP Credit Scheduler", > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.opt_name=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=3D "credit", > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.sched_id=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=3D XEN_SCHEDULER_CREDIT, > > -=C2=A0=C2=A0=C2=A0=C2=A0.sched_data=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D &= _csched_priv, > > +=C2=A0=C2=A0=C2=A0=C2=A0.sched_data=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D N= ULL, >=20 > You're maintainer of this code, so you know whether you really > want these NULL initializers, but the look pretty pointless to me. >=20 Yes, I've also been unsure about what to do here. The reason why I put them there is that, when looking at the code, it is important to be able to quickly get the idea of where sched_data points, at any given time. Therefore, being a little bit more verbose than necessary would be, in this case, actually helpful. Anyway, this is not a super strong opinion, so I can be talked into getting rid of them, if others think we better don't have them too. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-vTY7nrhxjM3cGW8l7348 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAla52r4ACgkQk4XaBE3IOsQthACeK6oK1HBXnpIxBKO/2sHwy6Mm CYcAoJUbIjbf5Z+hGhRNvcTOgGYJBVDo =UXGQ -----END PGP SIGNATURE----- --=-vTY7nrhxjM3cGW8l7348-- --===============8274346803888072294== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8274346803888072294==--