* [PATCH v3] hvmloader: Fix scratch_alloc to avoid overlaps
@ 2016-02-09 14:29 Anthony PERARD
0 siblings, 0 replies; only message in thread
From: Anthony PERARD @ 2016-02-09 14:29 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Andrew Cooper, Jan Beulich
scratch_alloc() set scratch_start to the last byte of the current
allocation. The value of scratch_start is then reused as is (if it is
already aligned) in the next allocation. This result in a potential reuse
of the last byte of the previous allocation.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
Change in v3:
- change to be similair to mem_alloc()
---
tools/firmware/hvmloader/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c
index d779fd7..9382709 100644
--- a/tools/firmware/hvmloader/util.c
+++ b/tools/firmware/hvmloader/util.c
@@ -478,7 +478,7 @@ void *scratch_alloc(uint32_t size, uint32_t align)
if ( align < 16 )
align = 16;
- s = (scratch_start + align - 1) & ~(align - 1);
+ s = (scratch_start + align) & ~(align - 1);
e = s + size - 1;
BUG_ON(e < s);
--
Anthony PERARD
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-02-09 14:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 14:29 [PATCH v3] hvmloader: Fix scratch_alloc to avoid overlaps Anthony PERARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).