xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com,
	daniel.kiper@oracle.com, mchang@suse.com
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping
Date: Thu, 11 Feb 2016 08:53:24 +0100	[thread overview]
Message-ID: <1455177206-8974-5-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1455177206-8974-1-git-send-email-jgross@suse.com>

Modern pvops linux kernels support an initrd not covered by the initial
mapping. This capability is flagged by an elf-note.

In case the elf-note is set by the kernel don't place the initrd into
the initial mapping. This will allow to load larger initrds and/or
support domains with larger memory, as the initial mapping is limited
to 2GB and it is containing the p2m list.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 grub-core/loader/i386/xen.c        | 56 ++++++++++++++++++++++++++++++--------
 grub-core/loader/i386/xen_fileXX.c |  3 ++
 include/grub/xen_file.h            |  1 +
 3 files changed, 49 insertions(+), 11 deletions(-)

diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c
index 65cec27..0f41048 100644
--- a/grub-core/loader/i386/xen.c
+++ b/grub-core/loader/i386/xen.c
@@ -307,15 +307,14 @@ grub_xen_pt_alloc (void)
 }
 
 static grub_err_t
-grub_xen_boot (void)
+grub_xen_alloc_end (void)
 {
   grub_err_t err;
-  grub_uint64_t nr_pages;
-  struct gnttab_set_version gnttab_setver;
-  grub_size_t i;
+  static int called = 0;
 
-  if (grub_xen_n_allocated_shared_pages)
-    return grub_error (GRUB_ERR_BUG, "active grants");
+  if (called)
+    return GRUB_ERR_NONE;
+  called = 1;
 
   err = grub_xen_p2m_alloc ();
   if (err)
@@ -327,6 +326,24 @@ grub_xen_boot (void)
   if (err)
     return err;
 
+  return GRUB_ERR_NONE;
+}
+
+static grub_err_t
+grub_xen_boot (void)
+{
+  grub_err_t err;
+  grub_uint64_t nr_pages;
+  struct gnttab_set_version gnttab_setver;
+  grub_size_t i;
+
+  if (grub_xen_n_allocated_shared_pages)
+    return grub_error (GRUB_ERR_BUG, "active grants");
+
+  err = grub_xen_alloc_end ();
+  if (err)
+    return err;
+
   err = set_mfns (console_pfn);
   if (err)
     return err;
@@ -587,6 +604,13 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
       goto fail;
     }
 
+  if (xen_inf.unmapped_initrd)
+    {
+      err = grub_xen_alloc_end ();
+      if (err)
+        goto fail;
+    }
+
   if (grub_initrd_init (argc, argv, &initrd_ctx))
     goto fail;
 
@@ -603,13 +627,22 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
 	goto fail;
     }
 
-  next_start.mod_start = max_addr + xen_inf.virt_base;
-  next_start.mod_len = size;
-
-  max_addr = ALIGN_UP (max_addr + size, PAGE_SIZE);
+  if (xen_inf.unmapped_initrd)
+    {
+      next_start.flags |= SIF_MOD_START_PFN;
+      next_start.mod_start = max_addr >> PAGE_SHIFT;
+      next_start.mod_len = size;
+    }
+  else
+    {
+      next_start.mod_start = max_addr + xen_inf.virt_base;
+      next_start.mod_len = size;
+    }
 
   grub_dprintf ("xen", "Initrd, addr=0x%x, size=0x%x\n",
-		(unsigned) next_start.mod_start, (unsigned) size);
+		(unsigned) (max_addr + xen_inf.virt_base), (unsigned) size);
+
+  max_addr = ALIGN_UP (max_addr + size, PAGE_SIZE);
 
 fail:
   grub_initrd_close (&initrd_ctx);
@@ -660,6 +693,7 @@ grub_cmd_module (grub_command_t cmd __attribute__ ((unused)),
 
   if (!xen_module_info_page)
     {
+      xen_inf.unmapped_initrd = 0;
       n_modules = 0;
       max_addr = ALIGN_UP (max_addr, PAGE_SIZE);
       modules_target_start = max_addr;
diff --git a/grub-core/loader/i386/xen_fileXX.c b/grub-core/loader/i386/xen_fileXX.c
index 1ba5649..69fccd2 100644
--- a/grub-core/loader/i386/xen_fileXX.c
+++ b/grub-core/loader/i386/xen_fileXX.c
@@ -253,6 +253,9 @@ parse_note (grub_elf_t elf, struct grub_xen_file_info *xi,
 					  descsz == 2 ? 2 : 3) == 0)
 	    xi->arch = GRUB_XEN_FILE_I386;
 	  break;
+	case 16:
+	  xi->unmapped_initrd = !!grub_le_to_cpu32(*(grub_uint32_t *) desc);
+	  break;
 	default:
 	  grub_dprintf ("xen", "unknown note type %d\n", nh->n_type);
 	  break;
diff --git a/include/grub/xen_file.h b/include/grub/xen_file.h
index 4b2ccba..ed749fa 100644
--- a/include/grub/xen_file.h
+++ b/include/grub/xen_file.h
@@ -36,6 +36,7 @@ struct grub_xen_file_info
   int has_note;
   int has_xen_guest;
   int extended_cr3;
+  int unmapped_initrd;
   enum
   {
     GRUB_XEN_FILE_I386 = 1,
-- 
2.6.2

  parent reply	other threads:[~2016-02-11  7:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455177206-8974-1-git-send-email-jgross@suse.com>
2016-02-11  7:53 ` [PATCH v2 1/6] xen: factor out p2m list allocation into separate function Juergen Gross
2016-02-11  7:53 ` [PATCH v2 2/6] xen: factor out allocation of special pages " Juergen Gross
2016-02-11  7:53 ` [PATCH v2 3/6] xen: factor out allocation of page tables " Juergen Gross
2016-02-11  7:53 ` Juergen Gross [this message]
2016-02-11 12:33   ` [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping Daniel Kiper
     [not found]   ` <20160211123352.GD3482@olila.local.net-space.pl>
2016-02-11 14:13     ` Juergen Gross
     [not found]     ` <56BC9714.7020101@suse.com>
2016-02-11 17:25       ` Daniel Kiper
     [not found]       ` <20160211172556.GH3482@olila.local.net-space.pl>
2016-02-12  6:25         ` Juergen Gross
     [not found]         ` <56BD7ABE.2050400@suse.com>
2016-02-12  8:15           ` Daniel Kiper
2016-02-12 12:24       ` Vladimir 'φ-coder/phcoder' Serbinenko
     [not found]       ` <56BDCF12.6050108@gmail.com>
2016-02-12 14:47         ` Juergen Gross
2016-02-11  7:53 ` [PATCH v2 5/6] xen: modify page table construction Juergen Gross
2016-02-11  7:53 ` [PATCH v2 6/6] xen: add capability to load p2m list outside of kernel mapping Juergen Gross
     [not found] ` <1455177206-8974-2-git-send-email-jgross@suse.com>
2016-02-11 12:19   ` [PATCH v2 1/6] xen: factor out p2m list allocation into separate function Daniel Kiper
     [not found]   ` <20160211121954.GA3482@olila.local.net-space.pl>
2016-02-11 12:38     ` Juergen Gross
     [not found]     ` <56BC80B2.4070102@suse.com>
2016-02-11 17:09       ` Daniel Kiper
     [not found]       ` <20160211170955.GF3482@olila.local.net-space.pl>
2016-02-12  6:27         ` Juergen Gross
     [not found] ` <1455177206-8974-3-git-send-email-jgross@suse.com>
2016-02-11 12:21   ` [PATCH v2 2/6] xen: factor out allocation of special pages " Daniel Kiper
2016-02-11 12:38     ` Juergen Gross
     [not found] ` <1455177206-8974-4-git-send-email-jgross@suse.com>
2016-02-11 12:27   ` [PATCH v2 3/6] xen: factor out allocation of page tables " Daniel Kiper
2016-02-11 12:53     ` Juergen Gross
     [not found]     ` <56BC845F.8080705@suse.com>
2016-02-11 17:14       ` Daniel Kiper
     [not found]       ` <20160211171405.GG3482@olila.local.net-space.pl>
2016-02-12  6:26         ` Juergen Gross
2016-02-12 12:20       ` Vladimir 'φ-coder/phcoder' Serbinenko
     [not found] ` <1455177206-8974-6-git-send-email-jgross@suse.com>
2016-02-11 12:47   ` [PATCH v2 5/6] xen: modify page table construction Daniel Kiper
2016-02-11 14:35     ` Juergen Gross
     [not found]     ` <56BC9C41.5000901@suse.com>
2016-02-11 17:48       ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455177206-8974-5-git-send-email-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=mchang@suse.com \
    --cc=phcoder@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).