[PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[Ian Campbell]

From: Doug Goldstein <cardoe@cardoe.com>

To help people avoid having to figure out what versions of gcc and
binutils need to be supported document them explicitly.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: [ijc] Updated version for binutils and include gcc (separately for
x86 and ARM in both cases), deferred make to second patch
---
 README | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/README b/README
index 1324c7c..356a350 100644
--- a/README
+++ b/README
@@ -35,9 +35,13 @@ Second, there are a number of prerequisites for building a Xen source
 release. Make sure you have all the following installed, either by
 visiting the project webpage or installing a pre-built package
 provided by your OS distributor:
-    * GCC v4.1 or later
+    * GCC
+      - For x86 4.1.2_20070115 or later
+      - For ARM 4.8 or later
     * GNU Make
-    * GNU Binutils
+    * GNU Binutils:
+      - For x86 2.16.91.0.5 or later
+      - For ARM 2.24 or later
     * Development install of zlib (e.g., zlib-dev)
     * Development install of Python v2.3 or later (e.g., python-dev)
     * Development install of curses (e.g., libncurses-dev)
-- 
2.1.4

[PATCH v3 2/2] build: specify minimum versions of make

[Ian Campbell]

From: Doug Goldstein <cardoe@cardoe.com>

To help people avoid having to figure out what versions of make
needs to be supported document it explicitly.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: [ijc] Put make into a separate patch to reduce risk to
gcc+binutils patch #1 (since I'm not sure if v3.80 was really agreed)
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README b/README
index 356a350..dd36ec8 100644
--- a/README
+++ b/README
@@ -38,7 +38,7 @@ provided by your OS distributor:
     * GCC
       - For x86 4.1.2_20070115 or later
       - For ARM 4.8 or later
-    * GNU Make
+    * GNU Make v3.80 or later
     * GNU Binutils:
       - For x86 2.16.91.0.5 or later
       - For ARM 2.24 or later
-- 
2.1.4

Re: [PATCH v3 2/2] build: specify minimum versions of make

[Andrew Cooper]

On 11/02/16 12:23, Ian Campbell wrote:
> From: Doug Goldstein <cardoe@cardoe.com>
>
> To help people avoid having to figure out what versions of make
> needs to be supported document it explicitly.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

In particular, I have had changes rejected before for using v3.81'isms,
whereas we have plenty of v3.80'isms

> ---
> v3: [ijc] Put make into a separate patch to reduce risk to
> gcc+binutils patch #1 (since I'm not sure if v3.80 was really agreed)
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README b/README
> index 356a350..dd36ec8 100644
> --- a/README
> +++ b/README
> @@ -38,7 +38,7 @@ provided by your OS distributor:
>      * GCC
>        - For x86 4.1.2_20070115 or later
>        - For ARM 4.8 or later
> -    * GNU Make
> +    * GNU Make v3.80 or later
>      * GNU Binutils:
>        - For x86 2.16.91.0.5 or later
>        - For ARM 2.24 or later

Re: [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[Andrew Cooper]

On 11/02/16 12:23, Ian Campbell wrote:
> From: Doug Goldstein <cardoe@cardoe.com>
>
> To help people avoid having to figure out what versions of gcc and
> binutils need to be supported document them explicitly.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

I would be tempted to abbreviate this to GCC 4.1 and Binutls 2.16,
unless we specifically know of issues between the release and point
releases.

Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
> v3: [ijc] Updated version for binutils and include gcc (separately for
> x86 and ARM in both cases), deferred make to second patch
> ---
>  README | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/README b/README
> index 1324c7c..356a350 100644
> --- a/README
> +++ b/README
> @@ -35,9 +35,13 @@ Second, there are a number of prerequisites for building a Xen source
>  release. Make sure you have all the following installed, either by
>  visiting the project webpage or installing a pre-built package
>  provided by your OS distributor:
> -    * GCC v4.1 or later
> +    * GCC
> +      - For x86 4.1.2_20070115 or later
> +      - For ARM 4.8 or later
>      * GNU Make
> -    * GNU Binutils
> +    * GNU Binutils:
> +      - For x86 2.16.91.0.5 or later
> +      - For ARM 2.24 or later
>      * Development install of zlib (e.g., zlib-dev)
>      * Development install of Python v2.3 or later (e.g., python-dev)
>      * Development install of curses (e.g., libncurses-dev)

Re: [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[Ian Campbell]

On Thu, 2016-02-11 at 12:31 +0000, Andrew Cooper wrote:
> On 11/02/16 12:23, Ian Campbell wrote:
> > From: Doug Goldstein <cardoe@cardoe.com>
> > 
> > To help people avoid having to figure out what versions of gcc and
> > binutils need to be supported document them explicitly.
> > 
> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> I would be tempted to abbreviate this to GCC 4.1 and Binutls 2.16,
> unless we specifically know of issues between the release and point
> releases.

I don't mind doing this but if there is any quibbling at all about it then
I would simply go with what is below.

> 
> Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> > ---
> > v3: [ijc] Updated version for binutils and include gcc (separately for
> > x86 and ARM in both cases), deferred make to second patch
> > ---
> >  README | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/README b/README
> > index 1324c7c..356a350 100644
> > --- a/README
> > +++ b/README
> > @@ -35,9 +35,13 @@ Second, there are a number of prerequisites for
> > building a Xen source
> >  release. Make sure you have all the following installed, either by
> >  visiting the project webpage or installing a pre-built package
> >  provided by your OS distributor:
> > -    * GCC v4.1 or later
> > +    * GCC
> > +      - For x86 4.1.2_20070115 or later
> > +      - For ARM 4.8 or later
> >      * GNU Make
> > -    * GNU Binutils
> > +    * GNU Binutils:
> > +      - For x86 2.16.91.0.5 or later
> > +      - For ARM 2.24 or later
> >      * Development install of zlib (e.g., zlib-dev)
> >      * Development install of Python v2.3 or later (e.g., python-dev)
> >      * Development install of curses (e.g., libncurses-dev)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[Jan Beulich]

>>> On 11.02.16 at 14:21, <ian.campbell@citrix.com> wrote:
> On Thu, 2016-02-11 at 12:31 +0000, Andrew Cooper wrote:
>> On 11/02/16 12:23, Ian Campbell wrote:
>> > From: Doug Goldstein <cardoe@cardoe.com>
>> > 
>> > To help people avoid having to figure out what versions of gcc and
>> > binutils need to be supported document them explicitly.
>> > 
>> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>> 
>> I would be tempted to abbreviate this to GCC 4.1 and Binutls 2.16,
>> unless we specifically know of issues between the release and point
>> releases.
> 
> I don't mind doing this but if there is any quibbling at all about it then
> I would simply go with what is below.

Yeah, I'd prefer the patches to go in as they're now: Both
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan

Re: [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

[Ian Campbell]

On Thu, 2016-02-11 at 06:32 -0700, Jan Beulich wrote:
> > > > On 11.02.16 at 14:21, <ian.campbell@citrix.com> wrote:
> > On Thu, 2016-02-11 at 12:31 +0000, Andrew Cooper wrote:
> > > On 11/02/16 12:23, Ian Campbell wrote:
> > > > From: Doug Goldstein <cardoe@cardoe.com>
> > > > 
> > > > To help people avoid having to figure out what versions of gcc and
> > > > binutils need to be supported document them explicitly.
> > > > 
> > > > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > 
> > > I would be tempted to abbreviate this to GCC 4.1 and Binutls 2.16,
> > > unless we specifically know of issues between the release and point
> > > releases.
> > 
> > I don't mind doing this but if there is any quibbling at all about it
> > then
> > I would simply go with what is below.
> 
> Yeah, I'd prefer the patches to go in as they're now: Both
> Acked-by: Jan Beulich <jbeulich@suse.com>

I have applied them both with you ack and Andy's R-by since he said "Either
way".

Thanks everyone.