From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data
Date: Thu, 11 Feb 2016 15:38:20 +0000 [thread overview]
Message-ID: <1455205100.814.69.camel@citrix.com> (raw)
In-Reply-To: <20160211111828.GD17384@citrix.com>
On Thu, 2016-02-11 at 11:18 +0000, Wei Liu wrote:
> On Wed, Feb 10, 2016 at 04:26:24PM +0000, Ian Campbell wrote:
> > Otherwise the fd is leaked. NB the mmap'd memory in the global
> > cpu_qos_data[n] is not affected by closing the underlying fd.
> >
> > Compile tested only.
> >
> > CID: 1055930
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied both, thanks.
prev parent reply other threads:[~2016-02-11 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:26 [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data Ian Campbell
2016-02-10 16:26 ` [PATCH 2/2] xenmon: initialise dummy array Ian Campbell
2016-02-11 11:19 ` Wei Liu
2016-02-11 11:18 ` [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data Wei Liu
2016-02-11 15:38 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455205100.814.69.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).